Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unstructured mesh file suffix to docstring #3211

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

shimwell
Copy link
Member

Description

As discovered in #3210 the openmc.UnstructuredMesh accepts vtk, h5 and exo files depending on which library is selected. This PR adds to the doc string to make the file type / extention clearer

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)

@shimwell shimwell requested a review from pshriwise November 27, 2024 17:19
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimwell! Also just a reminder that you should be using a fork for your local branches, not pushing them to the openmc-dev organization.

@paulromano paulromano enabled auto-merge (squash) December 3, 2024 04:45
@paulromano paulromano changed the title adding unstrucutred mesh file suffix to docstring Add unstructured mesh file suffix to docstring Dec 3, 2024
@paulromano paulromano merged commit de8132a into develop Dec 3, 2024
15 checks passed
@shimwell shimwell deleted the adding-unstrucutred-mesh-file-suffix branch December 3, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants