Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oneflow dist backend #59

Merged
merged 21 commits into from
Dec 6, 2022
Merged

add oneflow dist backend #59

merged 21 commits into from
Dec 6, 2022

Conversation

ofhwei
Copy link
Contributor

@ofhwei ofhwei commented Dec 4, 2022

Motivation

add oneflow dist backend for mmeval.

Modification

add oneflow dist backend for mmeval, corresponding to this PR #58

ice-tong
ice-tong reviewed Dec 5, 2022
View reviewed changes
mmeval/core/dist_backends/oneflow_dist.py Outdated Show resolved Hide resolved
mmeval/core/dist_backends/oneflow_dist.py Outdated Show resolved Hide resolved
mmeval/core/dist_backends/oneflow_dist.py Outdated Show resolved Hide resolved
zhouzaida
zhouzaida reviewed Dec 5, 2022
View reviewed changes
mmeval/core/dist.py Outdated Show resolved Hide resolved
ice-tong
ice-tong reviewed Dec 6, 2022
View reviewed changes
mmeval/core/dist_backends/oneflow_dist.py Outdated Show resolved Hide resolved
mmeval/core/dist_backends/oneflow_dist.py Outdated Show resolved Hide resolved
@ofhwei ofhwei force-pushed the add_oneflow_dist_backend branch from c633464 to d64405d Compare December 6, 2022 13:49
ice-tong
ice-tong approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhouzaida zhouzaida merged commit a188a20 into open-mmlab:main Dec 6, 2022
@zhouzaida zhouzaida mentioned this pull request Dec 6, 2022
Merged
@ofhwei ofhwei deleted the add_oneflow_dist_backend branch December 7, 2022 07:20
@openmmlab-bot
Copy link

Dear ofhwei,
First of all, we want to express our gratitude for your significant PR in the MMEval project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards！ @ofhwei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@ice-tong ice-tong ice-tong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ofhwei @openmmlab-bot @ice-tong @zhouzaida