Feature/limiters and profile refactor #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discard ext frames for data representation, get ext data from frame, which will eventually become called step
|
This will also break (in current form) for any previous custom profiles. Additional handling will have to be added for old custom profiles loading (which is why I hope this can be mitigated with the addition of the semver field. |
also recount frames/steps when saving or loading from json
use 0x80 on the high byte to tell de1 to ignore preinfusion frames when counting volume
match implementation to current firmware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limiters functionality added, together with range.
Also refactored profiles to make it work, because working both with frames and exFrames too soon turned out to be unproductive.
Might not build out of the box, since it's base branch was different and I might've forgotten to include something