Specify nodes number when updating cluster nodes

Now it allows updating cluster nodes without specify --nodes. It can write superblock with zero nodes. It can break the current cluster. Add this check to avoid this problem. v2: It needs check c.update first to avoid NULL pointer reference v3: Wol points the typo error Signed-off-by: Xiao Ni <[email protected]> Signed-off-by: Jes Sorensen <[email protected]>
neilbrown · Aug 7, 2020 · 138a9e9 · 138a9e9
1 parent 77b72fa
commit 138a9e9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/mdadm.c b/mdadm.c
@@ -1433,6 +1433,11 @@ int main(int argc, char *argv[])
 		}
 	}
 
+	if (c.update && strcmp(c.update, "nodes") == 0 && c.nodes == 0) {
+		pr_err("Please specify nodes number with --nodes\n");
+		exit(1);
+	}
+
 	if (c.backup_file && data_offset != INVALID_SECTORS) {
 		pr_err("--backup-file and --data-offset are incompatible\n");
 		exit(2);