Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for the PWA #896

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Quick fixes for the PWA #896

merged 6 commits into from
Sep 13, 2022

Conversation

dodumosu
Copy link
Collaborator

a couple of quick fixes for the PWA to resolve issues reported by @apommerNDI:

  • checklist display was failing for forms with multiselect fields.
  • added button to close a sent critical incident

- fix for crash when multiselect field exists in form
- render Close button at all times
@dodumosu dodumosu requested a review from takinbo September 12, 2022 12:09
- sort options for multiselect fields
- don't display last update for checklists if they haven't been updated
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@takinbo takinbo merged commit c565fd5 into nditech:develop Sep 13, 2022
takinbo pushed a commit to dodumosu/apollo that referenced this pull request Sep 14, 2022
- fix for crash when multiselect field exists in form
- render Close button at all times
- sort options for multiselect fields
- don't display last update for checklists if they haven't been updated

* fix: set empty array for multiselect fields
* chore: improve initializer for form list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants