Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix issue with depot middleware #784

Merged
merged 1 commit into from
Feb 1, 2021
Merged

fix: fix issue with depot middleware #784

merged 1 commit into from
Feb 1, 2021

Conversation

dodumosu
Copy link
Collaborator

this pull request reorders the middleware so that requests to image attachments do not fail with 404 responses.

@dodumosu dodumosu requested a review from takinbo January 28, 2021 00:53
takinbo
takinbo approved these changes Feb 1, 2021
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@takinbo takinbo merged commit 34f5e78 into nditech:develop Feb 1, 2021
@dodumosu dodumosu deleted the fix-middleware-issue branch February 9, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takinbo takinbo takinbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodumosu @takinbo