Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close tags in templates #782

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix: close tags in templates #782

merged 1 commit into from
Jan 27, 2021

Conversation

dodumosu
Copy link
Collaborator

this commit addresses nditech/apollo-issues#110 by replacing
the self-closing tags in the form builder component templates
with manually closed templates

@dodumosu dodumosu requested a review from takinbo January 11, 2021 17:10
@dodumosu
fix: close tags in templates
d6e1c1a 
this commit addresses nditech/apollo-issues#110 by replacing
the self-closing tags in the form builder component templates
with manually closed templates
@dodumosu dodumosu force-pushed the issue-110-form-builder branch from 6d0b521 to d6e1c1a Compare January 13, 2021 23:24
takinbo
takinbo approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@takinbo takinbo merged commit 7bda197 into nditech:develop Jan 27, 2021
@dodumosu dodumosu deleted the issue-110-form-builder branch February 9, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takinbo takinbo takinbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodumosu @takinbo