Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remplement overlapping events #728

Merged
merged 3 commits into from
Jul 28, 2020
Merged

feat: remplement overlapping events #728

merged 3 commits into from
Jul 28, 2020

Conversation

dodumosu
Copy link
Collaborator

this commit changes the way overlapping events work

prior to this, we'd retrieve all events that intersect temporally
with a specified event

now, all events intersecting temporally with the specified
event at a specific timestamp (which defaults to the current timestamp)
are returned instead

@dodumosu dodumosu requested a review from takinbo July 24, 2020 13:39
takinbo
takinbo requested changes Jul 26, 2020
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of creating a class method, why not simply re-implement the method in the services and leave the method signature as the same?

dodumosu added 2 commits July 27, 2020 13:34
@dodumosu
feat: remplement overlapping events
1378e8c 
this commit changes the way overlapping events work

prior to this, we'd retrieve all events that intersect temporally
with a specified event

now, all events intersecting temporally with the specified
event at a specific timestamp (which defaults to the current timestamp)
are returned instead
@dodumosu
chore: refactor overlap implementation
7218866
takinbo
takinbo approved these changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@takinbo takinbo merged commit d7103ab into nditech:develop Jul 28, 2020
@dodumosu dodumosu deleted the overlap-update branch September 23, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takinbo takinbo takinbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodumosu @takinbo