fix: add timestamp to form export #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit addresses the issues of form exports being cached by adding the UTC timestamp to the export filename. see: nditech/apollo-issues#19
takinbo
requested changes
Apr 8, 2020
takinbo
requested changes
Apr 8, 2020
apollo/formsframework/views_forms.py
Outdated
| @@ -407,7 +408,8 @@ def export_form(id): | |||
| workbook = utils.export_form(form) | |||
| workbook.save(memory_file) | |||
| memory_file.seek(0) | |||
| filename = '{}.xls'.format(form.name) | |||
| current_timestamp = datetime.utcnow() | |||
| filename = f'{form.name}-{current_timestamp:%Y %m %d %H%M%S}.xls' | |||
There was a problem hiding this comment.
This will leave spaces in the filename which is not what we want.
takinbo
requested changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit addresses the issues of form exports being cached
by adding the UTC timestamp to the export filename.
see: nditech/apollo-issues#19