bug #325: Fix print output in @at_cleanup functions not appearing in node console #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #325
printmessages aren't redirected to the Nodel console during clean-up.The issue appears to be that when the cleanup function(s) are triggered, the Python interpreter's system state isn't set correctly, and subsequently
sys.stdoutandsys.stderrredirects aren't established.This PR does the most obvious thing and (1) resets the interpreter's state and (2) assigns the output streams to the node's console before running through the list of clean-up functions provided by a node.