Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(neotest): prevent running multiple tests when running a single test with cargo-nextest #619

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(neotest): prevent running multiple tests when running a single test with cargo-nextest #619

merged 1 commit into from
Dec 17, 2024
+24 −1

Conversation

lpiepiora
Copy link
Contributor

@lpiepiora lpiepiora commented Dec 17, 2024 •
edited
Loading

Fixes #618.

I have tested this manually:

  1. Uninstalled the cargo-nextest
Screenshot 2024-12-17 at 15 45 39
  1. Installed 0.9.80 (which does not support the flag)
Screenshot 2024-12-17 at 15 49 26
  1. Installed the correct version
Screenshot 2024-12-17 at 15 52 03

I have tested the tests are now not executed if not needed (for example when running test_function_1:

    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.01s
────────────
 Nextest run ID a08a7486-cd35-4d6d-b0ce-4cde971c1b3c with nextest profile: default
    Starting 1 test across 1 binary (1 test skipped)
        PASS [   0.017s] rust-test::bin/rust-test test::test_function_1
────────────
     Summary [   0.019s] 1 test run: 1 passed, 1 skipped

@github-actions GitHub Actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

mrcjkb
mrcjkb requested changes Dec 17, 2024
View reviewed changes
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

lua/rustaceanvim/health.lua Outdated Show resolved Hide resolved
lua/rustaceanvim/health.lua Outdated Show resolved Hide resolved
@mrcjkb mrcjkb changed the title fix(neotest): prevent running multiple tests, when running a single test fix(neotest): prevent running multiple tests, when running a single test with cargo-nextest Dec 17, 2024
@mrcjkb mrcjkb changed the title fix(neotest): prevent running multiple tests, when running a single test with cargo-nextest fix(neotest): prevent running multiple tests when running a single test with cargo-nextest Dec 17, 2024
@mrcjkb mrcjkb enabled auto-merge (squash) December 17, 2024 17:42
@mrcjkb mrcjkb merged commit 152d1e7 into mrcjkb:master Dec 17, 2024
5 checks passed
@mrcjkb mrcjkb mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

neotest(nextest): when running a single test, multiple tests are ran (under some conditions)
2 participants
@lpiepiora @mrcjkb