Fix race condition when writing/committing index #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sync_all instead of flush to wait for the writes to be fully propagated to the file system before committing to the index repo.
|
Seems good to me, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggybacking on #21, use
sync_allinstead offlush.flushcommits the changes to the filesystem, but makes no guarantees as to when those changes will land in the fs. Instead, usesync_allto force the program to wait for the writes to be fully propagated to the file system before committing to the index repo. Otherwise it would sometimes happen that an empty file would be committed and pushed to the index before the additions were written to disk.Reference: https://stackoverflow.com/questions/69819990/whats-the-difference-between-flush-and-sync-all