Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add .m2 dependencies cache #3396

Merged
merged 1 commit into from
Jul 8, 2024
Merged

ci: add .m2 dependencies cache #3396

merged 1 commit into from
Jul 8, 2024

Conversation

brenoepics
Copy link
Contributor

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

Description

This pull request addresses an inefficiency in the current CI workflow. By adding a cache to the setup-java action, the CI process no longer needs to download ~530 MB of cacheable dependencies on every commit. This change not only reduces the load on external repositories like Maven Central but also significantly speeds up the build time.

Reference:

https://www.sonatype.com/blog/maven-central-and-the-tragedy-of-the-commons
https://github.com/actions/setup-java?tab=readme-ov-file#caching-packages-dependencies

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (a1cdede) to head (c3e4af8).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3396   +/-   ##
=========================================
  Coverage     85.36%   85.36%           
  Complexity     2927     2927           
=========================================
  Files           336      336           
  Lines          8908     8908           
  Branches       1110     1110           
=========================================
  Hits           7604     7604           
  Misses         1013     1013           
  Partials        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TimvdLippe TimvdLippe merged commit 4db0d7b into mockito:main Jul 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants