Improve bundle size by 2x #1

dawsbot · 2021-09-13T19:40:50Z

When comparing the size before this PR and after, it went:

Before

size: 87831,
gzip: 24612,

After

size: 42981,
gzip: 13020,

You can see from the original EIP that the keccak library is trusted by the Eth core devs and is a secure package: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md

Here are the bundle size comparisons:

https://bundlephobia.com/package/[email protected]
https://bundlephobia.com/package/[email protected]

Test the size diff yourself

// belongs in the parent directory to "ethereum-checksum-address"
import { getPackageStats } from "package-build-stats";
import path from "path";

(async () => {
  const results = await getPackageStats(
    path.join(__dirname, "ethereum-checksum-address"),
    {}
  );
  console.log({ results });
})();

My VSCode bundle diff

(this is made possible with https://github.com/wix/import-cost)

miguelmota · 2021-09-13T22:50:04Z

Hey @dawsbot! The PR looks good!

Merging 👍

Btw I'm the author of the package keccak256 which is just a simple wrapper over keccak that also includes a cli, which is the reason for larger size

dawsbot · 2021-09-14T00:43:53Z

Ooh, @miguelmota that makes sense! I like CLI's too, perhaps you could split them up the way sindresorhus does?

The cli imports the non-cli, so you'll never need meow in the js package 🙌

https://github.com/chalk/chalk-cli
https://github.com/chalk/chalk

dawsbot · 2021-09-14T00:45:09Z

We made the world a little better today 👌

https://bundlephobia.com/package/[email protected]

miguelmota · 2021-09-14T02:36:08Z

@dawsbot yep completely agree! that's the way to go

Replace keccak256 with light-weight keccak library

a3086a6

dawsbot changed the title ~~Replace keccak256 with light-weight keccak library~~ Improve bundle size by 2x Sep 13, 2021

miguelmota merged commit a807932 into miguelmota:master Sep 13, 2021

dawsbot deleted the trim-bundle-size branch September 14, 2021 00:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve bundle size by 2x #1

Improve bundle size by 2x #1

dawsbot commented Sep 13, 2021 •

edited

Loading

miguelmota commented Sep 13, 2021

dawsbot commented Sep 14, 2021

dawsbot commented Sep 14, 2021 •

edited

Loading

miguelmota commented Sep 14, 2021

Improve bundle size by 2x #1

Improve bundle size by 2x #1

Conversation

dawsbot commented Sep 13, 2021 • edited Loading

Test the size diff yourself

My VSCode bundle diff

miguelmota commented Sep 13, 2021

dawsbot commented Sep 14, 2021

dawsbot commented Sep 14, 2021 • edited Loading

miguelmota commented Sep 14, 2021

dawsbot commented Sep 13, 2021 •

edited

Loading

dawsbot commented Sep 14, 2021 •

edited

Loading