Fix timing issues with rapid protocol calls and missing dynamodb database fetch calls #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 6, 2020 10:47
Fix serverless offline connection issues on for apollo client quick succession of $connect and $default -> GQL_CONNECTION_INIT.
|
This fixes #67 |
michalkvasnicak
approved these changes
Feb 9, 2020
|
Thank you very much @nenti, released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running locally on a very powerful machine like the one used in continuous integration the calls coming from the graphql client of:
Can be quicker in the handler than the createConnection entry dynamodb call is taking to complete. This results into unexpected errors in the connection for local test runs and potentially also on production.
I fixed this by adding a retry mechanism to the connection hydration that is used for the initial call so it retrys once when the connection is not found.