Add libsolv.Database Bindings and tests #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ea0d37 to
1c97891
Compare
AntoinePrv
commented
Feb 9, 2024
| @@ -303,6 +306,12 @@ namespace mamba::fs | |||
| return to_utf8(m_path); | |||
| } | |||
|
|
|||
| // Returns a default encoded string. | |||
| const std::string& native() const | |||
There was a problem hiding this comment.
@Klaim I needed to add this function for pybind11, as it calls it and does utf-8 translation itself.
Is that OK?
There was a problem hiding this comment.
As long as it does what the standard does, that is returning the real native encoding of that the path use on that system, yes it's OK
I believe we didnt set this function to discourage trying to use something else than utf-8 with our library, but it's still just reflecting what the sandard does otherwise.
AntoinePrv
commented
Feb 9, 2024
Comment on lines
+44
to
+51
| if (src) | ||
| { | ||
| return make_caster<T>::cast(std::forward<Expected>(src).value(), policy, parent); | ||
| } | ||
| else | ||
| { | ||
| throw std::forward<Expected>(src).error(); | ||
| } |
There was a problem hiding this comment.
tl::expected now throws on unexpected cases.
1c97891 to
7af88e3
Compare
7af88e3 to
c369884
Compare
JohanMabille
approved these changes
Feb 10, 2024
| template <typename TT> | ||
| friend auto operator==(const conflict_map<TT>& lhs, const conflict_map<TT>& rhs) -> bool; | ||
| template <typename TT> | ||
| friend auto operator!=(const conflict_map<TT>& lhs, const conflict_map<TT>& rhs) -> bool; |
There was a problem hiding this comment.
Nitpicking: Only operator== has to be friend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.