Use libsolv wrappers in MPool and MRepo #2453
Conversation
AntoinePrv
commented
Apr 12, 2023
•
- For Solving Isolation #2302
- Based on Wrap ::Pool and ::Repo #2401
5de3c04 to
22117bf
Compare
f777757 to
45171d1
Compare
45171d1 to
ce01967
Compare
73fdd78 to
bc0b56a
Compare
11dd430 to
5dc9496
Compare
3a50327 to
22e447d
Compare
|
|
||
| private: | ||
| struct [[deprecated]] PyExtraPkgInfo |
There was a problem hiding this comment.
I'm not sure if [[deprecated]] is useful here as we'll change the major version?
There was a problem hiding this comment.
It's mostly for internal use, we'll know to remove it in the major release and it is to indicate that it is not needed internally anymore.
| namespace | ||
| { | ||
| /** Remove potential subdir from channel name (not url!). */ | ||
| auto cut_subdir(std::string_view str) -> std::string |
There was a problem hiding this comment.
I think we have similar code somewhere else in mamba, Iĺl try to find it.
|
|
||
|
|
||
| #define MAMBA_TOOL_VERSION "1.1" | ||
| #define MAMBA_TOOL_VERSION "1.3" |
There was a problem hiding this comment.
What is this version? libmamba is version 1.4.x at this point
There was a problem hiding this comment.
This is the version of the binary serialization of libsolv data. We slap our own version into it to update when we changes the internal libsolv data.
Probably not the best way to do this, because you need to deserialize it to be able to read it. We should think of something better...
|
|
||
| void ObjRepoView::legacy_read_conda_repodata(const fs::u8path& repodata_file, int flags) const | ||
| { | ||
| auto file = CFile::open(repodata_file, "rb"); |
There was a problem hiding this comment.
This is done in the CFile::open function.
|
Merging because this is a blocker and many reviewers are unavailable. |