fix Magento2.Legacy.EscapeMethodsOnBlockClass #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Morgy93 , thank you for your PR. Unfortunatly we cannot approve it now, as we still keep compatibility with Magento 2.3.0, and $escaper is available only in Magento >= 2.4.0. Once we drop Magento 2.3.x compatibility we will update the templates and add $escaper |
|
I am wondering why you keep 2.3.0 support if only 2.4.4+ are supported officially. (https://experienceleague.adobe.com/en/docs/commerce-operations/release/planning/lifecycle-policy) I would wish you focused more on motivating people to update, rather than rewarding them for using outdated and security-critical software. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using escape methods on $block is deprecated via Magento2.Legacy.EscapeMethodsOnBlockClass. Ref.: https://github.com/magento/magento-coding-standard/blob/v33/Magento2/Sniffs/Legacy/EscapeMethodsOnBlockClassSniff.php
This PR fixes it.