Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up object disposal and shutdown long running tasks. #143

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Clean up object disposal and shutdown long running tasks. #143

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e510c01
Add italics styles and others
hollandar Nov 1, 2021
5c6524b
Correct network printer construction and cleanup
hollandar Nov 2, 2021
5e34a8a
Centralize disposal in NetworkPrinter
hollandar Nov 2, 2021
22dc2b5
Move connect outside the constructors in all versions of BasePrinter.
hollandar Nov 2, 2021
c26c56b
Test Reader and Writer on base Connect.
hollandar Nov 2, 2021
ae21c0d
Dont write bytes to the device if it is in the disconnected state.
hollandar Nov 2, 2021
8a7e6d4
Update readme
hollandar Nov 2, 2021
2d78e5a
Remove Task.Run instances, no longer needed.
hollandar Nov 2, 2021
cb9fe8d
Clean up unwanted connect call.
hollandar Nov 2, 2021
5a8a925
Allow cancellation of device stream read
hollandar Nov 3, 2021
dbeef7a
Add alternate Left, Right and Center alignment Character Commands.
altie-webefinity Nov 8, 2021
44b7bfd
Move readers and writers to underlying classes
hollandar Nov 8, 2021
7c75694
Merge branch 'master' of https://github.com/hollandar/ESC-POS-.NET
altie-webefinity Nov 8, 2021
9c2d112
Flush write queue on dispose
hollandar Nov 18, 2021
699b9ac
Clean up unused items
hollandar Nov 21, 2021
958f304
Cancel after write and ensure write buffer is drained
hollandar Dec 5, 2021
7421550
Dont seek printer driver file
hollandar Dec 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Dont seek printer driver file
  • Loading branch information
@hollandar
hollandar committed Dec 12, 2021
commit 742155062ff12129feb043f15ed1c95583190e54
1 change: 1 addition & 0 deletions ESCPOS_NET/Printers/FilePrinter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public override void Connect(bool reconnecting = false)
else
{
_file = File.Open(filePath, FileMode.Open);
//if (_file.CanSeek) _file.Seek(0, SeekOrigin.End);
}

base.Connect(reconnecting);
Expand Down