Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving building with Visual Studio #537

Open
libffi:master
base: master
Choose a base branch
from

Conversation

DjArt
Copy link

Added support for ARM, Win32 & x64 targets to existing project.
Also added configurations for dynamic compilation.

@atgreen
Copy link
Member

atgreen commented Mar 24, 2021

Hi @DjArt . Thank you for your PR. There have been some recent changes and the patches no longer apply. Could you try adapting them, and I will be sure to merge them quickly? Thanks!

@nono303
Copy link

nono303 commented Feb 18, 2022

Hi @DjArt & Thx for this PR!
I've just merged and adapted it for https://github.com/libffi/libffi/tree/v3.4.2 without patch of src/closures.c
My fork is here https://github.com/nono303/libffi
I'll not make a PR here as i don't really understand the meaning of the change I've done on *.c & *.h ^^

fyi. I've tested it for vc15, vs16, vs17 x86 & x64 both static & dynamic with this build chain : https://github.com/nono303/win-build-scripts and all works great ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants