fix: migrate from globby to tinyglobby #4096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uninstall globby dependency - install tinyglobby dependency - replace usages of globby with tinyglobby in various files
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e760370. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
|
Per my other comment on the other PR, I have marked this as a fix |
benmccann
reviewed
Dec 14, 2024
| @@ -88,6 +87,7 @@ | |||
| "tar": "6.2.1", | |||
| "temp-dir": "1.0.0", | |||
| "tempy": "1.0.0", | |||
| "tinyglobby": "0.2.9", | |||
There was a problem hiding this comment.
I'd recommend upgrading to 0.2.10 here and in the other package.json files
Suggested change
| "tinyglobby": "0.2.9", | |
| "tinyglobby": "0.2.10", |
There was a problem hiding this comment.
Totally, I would wait for a review/approval first though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
globbydependencytinyglobbydependencyglobbywithtinyglobbyin various filesMotivation and Context
Closes es-tooling/ecosystem-cleanup#102
npmgraph.js.org?q=globby uses a total of 23 dependencies, while npmgraph.js.org?q=tinyglobby only uses 2.
How Has This Been Tested?
Types of changes
Checklist: