Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add disclaimer that Lerna is not a deployment tool #2089

Merged
merged 2 commits into from
May 15, 2019

Conversation

ajhool
Copy link
Contributor

@ajhool ajhool commented May 15, 2019

Description

Added a small disclaimer to the README about potential serverless monorepo incompatibility. Lerna is NOT a deployment tool! See #2077

Motivation and Context

Lerna might be mistaken as a serverless monorepo tool, but it has incompatibilities with the deployment process due, in part, to hoisting.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur changed the title Added a disclaimer to the README about serverless incompatibility docs: Add disclaimer that Lerna is not a deployment tool May 15, 2019
@evocateur evocateur merged commit c4d165a into lerna:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants