Orcid two factor authentication #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without autoload.php and the dependent phpseclib lib, it is not possible to use OpenID providers with a cert modulus and exponent. You need to run |
RBoelter
suggested changes
Jul 26, 2023
|
Thanks for your feedback. I've restored the autoloader requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this plugin. We will be using it on our OJS instance with OrcId as our openid provider, but in addition, we are requiring our users to enable 2FA in their OrcId accounts. The code in this PR enforces the 2FA requirement and adds this option to the OrcId section of the settings form.
Also, I was able to get the plugin working without requiring the vendor autoloader.php file on line 3 of OpenIDHandler. I'm not sure if I’m missing something important there or if that is leftover from a previous approach.
-Jack