Pin lexer logos dependency to 0.14.2 for now #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.14.3 bumps msrv to 1.74, so our CI test for 1.70 build is currently failing. This can be removed once our MSRV moves to 1.74 or later.
Pat-Lafon
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Kind of surprising/annoying that dependencies of logos also need to be pinned to have the desired effect.
Seems like future cargo resolvers will better support this but it doesn't currently help with our workflow of using an older rust: rust-lang/cargo#13540
dburgener
added a commit
to dburgener/lalrpop
that referenced
this pull request
Dec 3, 2024
This reverts commit 6b30a0f. This change is no longer needed once the MSRV is bumped past 1.74
dburgener
added a commit
to dburgener/lalrpop
that referenced
this pull request
Dec 4, 2024
This reverts commit 6b30a0f. This change is no longer needed once the MSRV is bumped past 1.74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.14.3 bumps msrv to 1.74, so our CI test for 1.70 build is currently
failing.
This can be removed once our MSRV moves to 1.74 or later.