Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatiable with ruby 3 #440

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

aniketstiwari
Copy link

No description provided.

@aniketstiwari
Copy link
Author

@kyleboe When you get a chance. Could you please review it?

Copy link
Owner

@kyleboe kyleboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just one small change then I'll get it merged.

CHANGELOG.md Outdated
@@ -86,4 +86,4 @@ This is the first CHANGELOG entry.
### Misc:
* Update gems
* Update bundler to 2.2
* Update Ruby to 2.7
* Update Ruby to 3.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update Ruby to 3.0
* Update Ruby to 2.7

Lets revert this change. I'll add an entry to update the changelog after we get this merged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyleboe Done

@aniketstiwari aniketstiwari requested a review from kyleboe October 11, 2022 10:56
@kyleboe
Copy link
Owner

kyleboe commented Oct 11, 2022

Thanks for the update! I'll get a new version of the gem published soon.

@kyleboe kyleboe merged commit c4efaf0 into kyleboe:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants