Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt execve rare error #167

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: attempt execve rare error #167

merged 3 commits into from
Jan 17, 2025

Conversation

qjerome
Copy link
Member

@qjerome qjerome commented Jan 15, 2025

This PR attempts at fixing a rare error happening in execve probe (see #159)

The occurence of this error seems pretty random, so it is impossible to replicate (so far).

Thus some code review has been done on the probe and we fix possible cause of this error:

  • the probe uses two maps of different sizes, that may cause data to be missing in one of them -> fix: put the same size for both the maps
  • proper cleanup of both the maps

This PR attempts at fixing a rare error happening in `execve` probe (see #159)

The occurence of this error seems pretty random, so it is impossible to replicate (so far).

Thus some code review has been done on the probe and we fix possible cause of this error:
- the probe uses two maps of different sizes, that may cause data to be missing in one of them -> fix: put the same size for both the maps
- offload work from execve_event to try_security_bprm_check
- changed MAP_SIZE to 2048 instead of 4096
@qjerome qjerome merged commit 29e3bb1 into main Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant