Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent event #162

Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat: agent event #162

merged 1 commit into from
Jan 10, 2025

Conversation

qjerome
Copy link
Member

@qjerome qjerome commented Jan 10, 2025

This PR brings a way to create events coming from kunai itself

It is motivated by the need to bubble up some important information into the Kunai events themselves, as those may be stored in a central place (splunk, OpenSearch ...). Having some information directly accessible in the logs prevents having to parse an additional log source (service logs) and also having to correlate with them.

This PR also provides a concrete use of agent event by including the implementation of an event when data loss occurs. Hereafter is an example of such an event:

{
  "data": {
    "read": 873763,
    "lost": 33574,
    "eps": 11745.90217874584
  },
  // info section similar to all other events
  "info":  "..."

This PR will serve as a foundation work to implement more agent logs such as start and stop events.

@qjerome qjerome merged commit f0ca0a2 into main Jan 10, 2025
2 checks passed
@qjerome qjerome deleted the feat-agent-event branch January 10, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant