Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove kic overlay network for docker-runtime #7425

Merged
merged 8 commits into from
Apr 7, 2020
Merged

remove kic overlay network for docker-runtime #7425

merged 8 commits into from
Apr 7, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 5, 2020 •
edited by sharifelgamal
Loading

After the refactor that we fixed the control-endpoint in the config, we no longer need to use kic overlay network.

After this PR:

  • save 3 seconds by not waiting for applying kic overlay network on the default runtime (docker)
  • save disk space by not storing kindnet image
  • make preload images 78mb smaller for docker ( for the next version of preload images)

does this PR affect multi node ?

no.

the mutli node start works fine as is now

medmac@~/workspace/minikube (remove_overlay) $ ./out/minikube start --driver=docker -n=2
😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node m01 in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=4000MB (7964MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner

👍  Starting node m02 in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=4000MB (7964MB available) ...
🌐  Found network options:
    ▪ NO_PROXY=172.17.0.2
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
🏄  Done! kubectl is now configured to use "minikube"
medmac@~/workspace/minikube (remove_overlay) $ kc get nodes
NAME           STATUS   ROLES    AGE    VERSION
minikube       Ready    master   103s   v1.18.0
minikube-m02   Ready    <none>   56s    v1.18.0

other operations of multi node is broken even before this PR see #7423
I belive to make this service work in multi node we currently need flannel (which means we do not use kic overlay network anyways_

FUTURE PRs:

this PR does not remove kic overaly for containerd and crio as they are still needed till we address #7428

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from RA489 and tstromberg April 5, 2020 06:17
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2020
@medyagh medyagh requested a review from sharifelgamal April 5, 2020 06:18
@medyagh
Copy link
Member Author

medyagh commented Apr 5, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 5, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

All Times minikube: [ 67.811693 66.726201 69.964213]
All Times Minikube (PR 7425): [ 66.219334 65.154139 66.372942]

Average Minikube (PR 7425): 65.915472
Average minikube: 68.167369

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7425) |
+----------------------+-----------+--------------------+
| minikube v           |  0.165994 |           0.147833 |
| Creating kvm2        | 41.614727 |          40.505505 |
| Preparing Kubernetes | 24.079695 |          22.860833 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@codecov-io
Copy link

codecov-io commented Apr 5, 2020 •
edited
Loading

Codecov Report

Merging #7425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7425   +/-   ##
=======================================
  Coverage   37.07%   37.07%           
=======================================
  Files         146      146           
  Lines        8871     8871           
=======================================
  Hits         3289     3289           
  Misses       5193     5193           
  Partials      389      389

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2020
@medyagh medyagh changed the title remove kic overlay network remove kic overlay network for docker-runtime Apr 5, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 65.342405 65.927637 66.087881]
All Times Minikube (PR 7425): [ 69.577527 66.955970 67.072377]

Average Minikube (PR 7425): 67.868625
Average minikube: 65.785975

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7425) |
+----------------------+-----------+--------------------+
| minikube v           |  0.200845 |           0.149551 |
| Creating kvm2        | 40.927543 |          41.530749 |
| Preparing Kubernetes | 22.489895 |          23.833492 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 72.209324 66.259597 68.501424]
All Times Minikube (PR 7425): [ 66.815233 66.348925 65.204438]

Average minikube: 68.990115
Average Minikube (PR 7425): 66.122865

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7425) |
+----------------------+-----------+--------------------+
| minikube v           |  0.160841 |           0.147707 |
| Creating kvm2        | 42.304334 |          41.333587 |
| Preparing Kubernetes | 23.837309 |          22.670160 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

priyawadhwa
priyawadhwa reviewed Apr 6, 2020
View reviewed changes
Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- could you please bump up the preload version here? Then this should be good to merge

@minikube-pr-bot
Copy link

All Times minikube: [ 65.809755 80.733934 66.401384]
All Times Minikube (PR 7425): [ 117.080021 101.167714 104.503714]

Average minikube: 70.981691
Average Minikube (PR 7425): 107.583817

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7425) |
+----------------------+-----------+--------------------+
| minikube v           |  0.768167 |           0.265967 |
| Creating kvm2        | 45.333227 |          19.987044 |
| Preparing Kubernetes | 22.664453 |          84.695577 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member Author

medyagh commented Apr 7, 2020

LGTM -- could you please bump up the preload version here? Then this should be good to merge

good idea, I will do that in a separate PR so we can have the images generted first for the tests

@minikube-pr-bot
Copy link

All Times minikube: [ 65.881905 68.735191 66.247498]
All Times Minikube (PR 7425): [ 102.423023 101.233763 104.979814]

Average minikube: 66.954865
Average Minikube (PR 7425): 102.878866

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7425) |
+----------------------+-----------+--------------------+
| minikube v           |  0.264344 |           0.242494 |
| Creating kvm2        | 41.537173 |          19.579638 |
| Preparing Kubernetes | 22.737958 |          80.799782 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit d84b942 into kubernetes:master Apr 7, 2020
@medyagh medyagh deleted the remove_overlay branch May 2, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa left review comments

RA489 Awaiting requested review from RA489

@tstromberg tstromberg Awaiting requested review from tstromberg

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@medyagh @k8s-ci-robot @minikube-pr-bot @codecov-io @priyawadhwa