Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend maximum stop retry from 30s to 120s #7363

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Extend maximum stop retry from 30s to 120s #7363

merged 1 commit into from
Apr 1, 2020

Conversation

tstromberg
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #7363 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7363      +/-   ##
==========================================
- Coverage   37.16%   37.11%   -0.05%     
==========================================
  Files         145      145              
  Lines        8762     8772      +10     
==========================================
  Hits         3256     3256              
- Misses       5110     5120      +10     
  Partials      396      396
Impacted Files Coverage Δ
cmd/minikube/cmd/stop.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/start.go 35.64% <0.00%> (-0.52%) ⬇️
cmd/minikube/cmd/update-context.go 0.00% <0.00%> (ø)

@tstromberg tstromberg merged commit 5306702 into kubernetes:master Apr 1, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @codecov-io @medyagh