Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON output for addons list #5601

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Add JSON output for addons list #5601

merged 1 commit into from
Oct 21, 2019

Conversation

woodcockjosh
Copy link
Contributor

@woodcockjosh woodcockjosh commented Oct 11, 2019 •
edited
Loading

Depends on #5555

Before

Command:

minikube addons list -o json

Output:

Error: unknown shorthand flag: 'o' in -o


Usage:
  minikube addons list [flags] [options]

Use "minikube addons options" for a list of global command-line options (applies to all commands).

After

Command:

minikube addons list -o json

Output:

{"addon-manager":{"Status":"enabled"},"dashboard":{"Status":"enabled"},"default-storageclass":{"Status":"enabled"},"efk":{"Status":"disabled"},"freshpod":{"Status":"disabled"},"gvisor":{"Status":"disabled"},"heapster":{"Status":"disabled"},"helm-tiller":{"Status":"disabled"},"ingress":{"Status":"enabled"},"ingress-dns":{"Status":"enabled"},"logviewer":{"Status":"disabled"},"metrics-server":{"Status":"enabled"},"nvidia-driver-installer":{"Status":"disabled"},"nvidia-gpu-device-plugin":{"Status":"disabled"},"registry":{"Status":"disabled"},"registry-creds":{"Status":"disabled"},"storage-provisioner":{"Status":"enabled"},"storage-provisioner-gluster":{"Status":"disabled"}}

Output and Format options cannot both be used at the same time

Command:

minikube addons list -o json -f "hello"

Output:

💡  Cannot use both --output and --format options

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @woodcockjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@woodcockjosh
Copy link
Contributor Author

/assign @medyagh

@woodcockjosh woodcockjosh force-pushed the json-output-for-addons-list branch from f026626 to b8c3fe4 Compare October 11, 2019 18:47
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: woodcockjosh
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

codecov-io commented Oct 11, 2019 •
edited
Loading

Codecov Report

Merging #5601 into master will decrease coverage by 0.57%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5601      +/-   ##
==========================================
- Coverage   37.45%   36.88%   -0.58%     
==========================================
  Files         103      102       -1     
  Lines        7540     7399     -141     
==========================================
- Hits         2824     2729      -95     
+ Misses       4342     4317      -25     
+ Partials      374      353      -21
Impacted Files Coverage Δ
cmd/minikube/cmd/config/addons_list.go 23.8% <18.18%> (-0.52%) ⬇️
cmd/minikube/cmd/delete.go 0% <0%> (-30%) ⬇️
cmd/minikube/cmd/config/util.go 24.81% <0%> (-9.5%) ⬇️
cmd/minikube/cmd/config/validations.go 31.34% <0%> (-4.48%) ⬇️
pkg/minikube/cluster/cluster.go 37.46% <0%> (-0.48%) ⬇️
pkg/minikube/assets/addons.go 36.66% <0%> (ø) ⬆️
pkg/minikube/cluster/machine.go
cmd/minikube/cmd/dashboard.go 1.78% <0%> (+0.01%) ⬆️
cmd/minikube/cmd/config/open.go 15.55% <0%> (+0.33%) ⬆️
cmd/minikube/cmd/service.go 26.92% <0%> (+0.99%) ⬆️
... and 1 more

sharifelgamal
sharifelgamal reviewed Oct 11, 2019
View reviewed changes
cmd/minikube/cmd/config/addons_list.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/config/addons_list.go Outdated Show resolved Hide resolved
@woodcockjosh woodcockjosh force-pushed the json-output-for-addons-list branch 2 times, most recently from 5507db0 to 9553c5d Compare October 11, 2019 19:04
@woodcockjosh
Copy link
Contributor Author

@sharifelgamal thanks for the review!

@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

@woodcockjosh woodcockjosh force-pushed the json-output-for-addons-list branch from 9553c5d to 60bd68d Compare October 11, 2019 20:33
@tstromberg tstromberg mentioned this pull request Oct 14, 2019
Closed
@woodcockjosh woodcockjosh force-pushed the json-output-for-addons-list branch from 60bd68d to 1875a62 Compare October 17, 2019 21:15
@woodcockjosh woodcockjosh force-pushed the json-output-for-addons-list branch from 1875a62 to b132b04 Compare October 17, 2019 21:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2019
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2019
@tstromberg tstromberg merged commit 723e77e into kubernetes:master Oct 21, 2019
@woodcockjosh woodcockjosh deleted the json-output-for-addons-list branch October 21, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal left review comments

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees

@medyagh medyagh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@woodcockjosh @k8s-ci-robot @minikube-bot @codecov-io @sharifelgamal @tstromberg @medyagh