Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change systemd unit files perm to 644 #5492

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Change systemd unit files perm to 644 #5492

merged 1 commit into from
Oct 8, 2019

Conversation

laozc
Copy link
Contributor

systemd complains about the conf file is not world-inaccessible

Signed-off-by: Zhongcheng Lao [email protected]

Change systemd unit files perm to 644
4ab0834 
systemd complains about the conf file is not world-inaccessible

Signed-off-by: Zhongcheng Lao <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Sep 29, 2019

I am curious is there a related issue you could reference? I like to see the before and after and how this PR would fix the issue

Copy link
Contributor Author

Not sure if there is a pending issue filed for it.
But I saw this when I tried to debug the integration test failure for my other PR.

$ journalctl --no-pager|grep world
Sep 29 14:31:33 gvisor systemd[1]: Configuration file /usr/lib/systemd/system/kubelet.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.
Sep 29 14:31:33 gvisor systemd[1]: Configuration file /etc/systemd/system/kubelet.service.d/10-kubeadm.conf is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.
Sep 29 14:31:46 gvisor systemd[1]: Configuration file /usr/lib/systemd/system/kubelet.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.
Sep 29 14:31:46 gvisor systemd[1]: Configuration file /etc/systemd/system/kubelet.service.d/10-kubeadm.conf is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.

It simply suppresses this systemd warning.

@medyagh
Copy link
Member

medyagh commented Oct 2, 2019

Not sure if there is a pending issue filed for it.
But I saw this when I tried to debug the integration test failure for my other PR.

$ journalctl --no-pager|grep world
Sep 29 14:31:33 gvisor systemd[1]: Configuration file /usr/lib/systemd/system/kubelet.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.
Sep 29 14:31:33 gvisor systemd[1]: Configuration file /etc/systemd/system/kubelet.service.d/10-kubeadm.conf is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.
Sep 29 14:31:46 gvisor systemd[1]: Configuration file /usr/lib/systemd/system/kubelet.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.
Sep 29 14:31:46 gvisor systemd[1]: Configuration file /etc/systemd/system/kubelet.service.d/10-kubeadm.conf is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.

It simply suppresses this systemd warning.

Thank you for providing the reason, could you verify that after this PR the warning goes away ?

if you could prove me that ! I am okay with this being merged !

medyagh
medyagh requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could provide me logs that the gvisor warrning goes away after this PR. I approve.

Copy link
Contributor Author

@medyagh You may check the enclosed log (journalctl --no-pager > journalctl.log)
journalctl.log

grep 'world-inaccessible' journalctl.log should give you empty output.

@medyagh
Copy link
Member

medyagh commented Oct 6, 2019

@minikube-bot OK to test

@medyagh medyagh merged commit da8500a into kubernetes:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-ci-robot @minikube-bot @medyagh