Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kubernetes default version to v1.15.0 #4534

Merged
merged 4 commits into from
Jun 22, 2019
Merged

Update Kubernetes default version to v1.15.0 #4534

merged 4 commits into from
Jun 22, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Jun 19, 2019 •
edited
Loading

Also, refactor the kubeadm tests to decrease toil when new releases are made. This happened to also mean that testdata for v1.11.x was added as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2019
@tstromberg tstromberg requested a review from medyagh June 19, 2019 23:37
@tstromberg
Copy link
Contributor Author

tstromberg commented Jun 19, 2019 •
edited
Loading

Feel free to merge if test results look good, as I'll be mostly out of reach this week. Thanks!

@medyagh
Copy link
Member

medyagh commented Jun 19, 2019

/retest this please

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2019
@tstromberg tstromberg changed the title Update Kubernetes default version to v1.15.0 WIP: Update Kubernetes default version to v1.15.0 Jun 20, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2019
@tstromberg
Copy link
Contributor Author

Still needs some test data updates.

@medyagh
Copy link
Member

medyagh commented Jun 20, 2019

Still needs some test data updates.

seems like the unit tests failed in travis:

            ---
            apiVersion: kubeadm.k8s.io/v1beta1
            kind: ClusterConfiguration
            imageRepository: test/repo
            apiServer:
              extraArgs:
                enable-admission-plugins: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
            certificatesDir: /var/lib/minikube/certs/
            clusterName: kubernetes
            controlPlaneEndpoint: localhost:8443
            dns:
              type: CoreDNS
            etcd:
              local:
                dataDir: /data/minikube
            kubernetesVersion: v1.14.0
            networking:
              dnsDomain: cluster.local
              podSubnet: ""
              serviceSubnet: 10.96.0.0/12
            ---
            apiVersion: kubelet.config.k8s.io/v1beta1
            kind: KubeletConfiguration
            imageGCHighThresholdPercent: 100
            evictionHard:
              nodefs.available: "0%"
              nodefs.inodesFree: "0%"
              imagefs.available: "0%"
FAIL
coverage: 33.1% of statements
FAIL	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.052s

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2019
@tstromberg tstromberg changed the title WIP: Update Kubernetes default version to v1.15.0 Update Kubernetes default version to v1.15.0 Jun 20, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot ok to test

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

2 similar comments
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

hyperkit failure is unrelated CI issue with the new Mac being brought up.

@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

@sharifelgamal
Copy link
Collaborator

The none test failure is a flake.

@sharifelgamal sharifelgamal merged commit 247efde into master Jun 22, 2019
@medyagh medyagh deleted the k8s-1.15.0 branch November 6, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@balopat balopat Awaiting requested review from balopat

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @medyagh @sharifelgamal