Make default output of 'minikube start' consume fewer lines in the terminal #4197
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @dpandhi-git. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dpandhi-git If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
@minikube-bot OK to test |
|
The Travis failures are just simple gofmt issues. |
|
OSX-Hyperkit test failure seems to be an unrelated flake. CLA issue still needs to be addressed though. It seems like the first commits don't have their name/address matched to your GitHub user: |
There was a problem hiding this comment.
Looks great! To close the issue, I think this PR should also change the following call in kubeadm.go to glog.Infof:
console.OutStyle("permissions", "Configuring cluster permissions ...")
I think we can also safely remove the console.Out calls in start.go:validateCluster()
Thanks for taking this on!
cmd/minikube/cmd/start.go
Outdated
| } | ||
|
|
||
| func showKubectlConnectInfo(kubeconfig *pkgutil.KubeConfigSetup) { | ||
| if kubeconfig.KeepContext { | ||
| console.OutStyle("kubectl", "To connect to this cluster, use: kubectl --context=%s", kubeconfig.ClusterName) | ||
| } else { | ||
| console.OutStyle("kubectl", "kubectl is now configured to use %q", cfg.GetMachineName()) | ||
| console.OutStyle("kubectl", "Done! kubectl is now configured to use %q", cfg.GetMachineName()) |
There was a problem hiding this comment.
This should use the "ready" style.
|
Can anyone help with latest travis build failed? Also I might need help for cla/linux foundation error. I tried the steps mentioned in details but it does not seem to work. My git account has two email ids one primary is E1 and other is E2 . E2 one is used when login with linux foundation to sign the CLA will that cause any issue? was checking people have faced similar issue cncf/foundation#26 (comment) |
|
@minikube-bot OK to test |
|
The broken Travis build was my fault - and should not happen again. It appears that this commit is not associated to your GitHub e-mail address: https://github.com/kubernetes/minikube/commit/ee4e514282811a95dcc4c6bf31f3f4c868aa1890.patch The e-mail address for this commit is [email protected] https://gist.github.com/trey/9588090 explains how to go back and fix the e-mail address for an older commit in a PR. Hope this helps! I can't wait for this change to land =) |
Thanks for info on git. Passed CLA test. Thanks for making my first contribution to K8s successful |
|
Thank you! |
This PR fixes #4187