Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses issue #18724 "minikube mount does not work on 6.1.0-20-cloud-amd64" - Detect when OS does not support 9p #18995

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Addresses issue #18724 "minikube mount does not work on 6.1.0-20-cloud-amd64" - Detect when OS does not support 9p #18995

merged 4 commits into from
Jun 3, 2024

Conversation

xcarolan
Copy link
Contributor

@xcarolan xcarolan commented May 30, 2024 •
edited by spowelljr
Loading

Addresses issue #18724 "minikube mount does not work on 6.1.0-20-cloud-amd64" - Detect when OS does not support 9p
Fixes #18724

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xcarolan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented May 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18995) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 46.5s               |
| enable ingress | 24.5s    | 24.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.9s 23.9s 23.8s 23.9s 24.9s
Times for minikube (PR 18995) ingress: 23.8s 23.9s 23.8s 27.4s 24.9s

Times for minikube start: 48.6s 49.5s 45.7s 48.0s 48.4s
Times for minikube (PR 18995) start: 46.6s 45.5s 47.0s 45.6s 47.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18995) |
+----------------+----------+---------------------+
| minikube start | 20.9s    | 21.9s               |
| enable ingress | 21.8s    | 21.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.7s 22.7s 21.7s 21.7s 21.2s
Times for minikube (PR 18995) ingress: 21.2s 21.7s 21.2s 22.7s 22.2s

Times for minikube (PR 18995) start: 22.8s 23.0s 23.2s 20.8s 19.7s
Times for minikube start: 20.1s 20.3s 23.7s 20.3s 20.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18995) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.4s               |
| enable ingress | 35.6s    | 35.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 19.8s 23.3s 22.0s 22.8s
Times for minikube (PR 18995) start: 22.3s 19.9s 21.6s 23.1s 20.2s

Times for minikube ingress: 33.2s 32.2s 33.2s 48.2s 31.2s
Times for minikube (PR 18995) ingress: 32.2s 32.2s 48.2s 32.2s 32.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestMultiControlPlane/serial/DeleteSecondaryNode (gopogh) 0.63 (chart)
KVM_Linux_crio TestMultiControlPlane/serial/RestartCluster (gopogh) 0.63 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Volcano (gopogh) 0.96 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/InspektorGadget (gopogh) 1.25 (chart)
Docker_Linux_containerd_arm64 TestAddons/StoppedEnableDisable (gopogh) 1.25 (chart)
KVM_Linux_crio TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 1.54 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 2.52 (chart)
KVM_Linux_crio TestAddons/Setup (gopogh) 17.61 (chart)

To see the flake rates of all tests by environment, click here.

medyagh
medyagh approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, tests are good

@medyagh medyagh marked this pull request as ready for review June 3, 2024 18:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, xcarolan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@medyagh medyagh merged commit 2faab76 into kubernetes:master Jun 3, 2024
37 of 51 checks passed
@xcarolan xcarolan deleted the 18724-1 branch June 3, 2024 21:53
@spowelljr spowelljr mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prezha prezha Awaiting requested review from prezha

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube mount does not work on 6.1.0-20-cloud-amd64 - Detect when OS does not support 9p
5 participants
@xcarolan @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot