Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNI kindnet: Update from v20230330-48f316cd to v20230511-dc714da8 #16488

Merged
merged 2 commits into from
May 16, 2023
Merged

CNI kindnet: Update from v20230330-48f316cd to v20230511-dc714da8 #16488

merged 2 commits into from
May 16, 2023

Conversation

spowelljr
Copy link
Member

  • Fixes 1 critical and 3 high CVEs
  • Updates distroless-iptables from v0.2.2 to v0.2.3
  • Change base image from Ubuntu to Debian

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha May 11, 2023 18:04
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr spowelljr changed the title CNI kindnet: Update from v20230330-48f316cd to v20230510-486859a6 CNI kindnet: Update from v20230330-48f316cd to v20230511-dc714da8 May 15, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16488) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 49.8s               |
| enable ingress | 28.5s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.2s 28.6s 29.7s 28.2s 27.7s
Times for minikube (PR 16488) ingress: 28.2s 28.7s 28.7s 28.2s 28.2s

Times for minikube (PR 16488) start: 49.6s 47.4s 50.9s 50.0s 51.1s
Times for minikube start: 51.7s 49.1s 48.7s 52.1s 50.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16488) |
+----------------+----------+---------------------+
| minikube start | 24.2s    | 24.8s               |
| enable ingress | 21.7s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 22.2s 26.3s 25.2s 24.2s
Times for minikube (PR 16488) start: 25.2s 26.5s 21.9s 25.2s 25.0s

Times for minikube ingress: 20.9s 22.8s 19.9s 22.4s 22.4s
Times for minikube (PR 16488) ingress: 20.9s 20.9s 23.9s 20.9s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16488) |
+----------------+----------+---------------------+
| minikube start | 20.9s    | 22.1s               |
| enable ingress | 42.4s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.4s 38.4s 31.4s 31.4s 79.4s
Times for minikube (PR 16488) ingress: 31.4s 31.4s 31.4s 31.4s 30.4s

Times for minikube start: 20.2s 23.0s 20.7s 20.2s 20.4s
Times for minikube (PR 16488) start: 20.2s 20.8s 21.1s 24.0s 24.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 1.22 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 2.02 (chart)
KVM_Linux_crio TestErrorSpam/setup (gopogh) 9.15 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 46.46 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 820adeb into kubernetes:master May 16, 2023
@spowelljr spowelljr deleted the updateKindnetd branch May 25, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh Awaiting requested review from medyagh

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spowelljr @k8s-ci-robot @minikube-pr-bot @medyagh