Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minikube license command #15158

Merged
merged 6 commits into from
Oct 24, 2022
Merged

Add minikube license command #15158

merged 6 commits into from
Oct 24, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Oct 17, 2022 •
edited
Loading

On releases, make generate-licenses is ran, it downloads all the licenses from dependencies, tars them, and uploads them to GCS.

Then, when the minikube license command is ran it downloads the licenses tar and untars them to the directory specified by -d or --dir (defaults to the current dir).

$ minikube license -d ./here
$ minikube ls -la ./here/licenses
total 0
drwxr-xr-x  12 ...  primarygroup   384 Oct 17 15:35 .
drwxr-xr-x  43 ...  primarygroup  1376 Oct 17 15:35 ..
drwxr-xr-x   3 ...  primarygroup    96 Oct 17 15:33 cloud.google.com
drwxr-xr-x  68 ...  primarygroup  2176 Oct 17 15:33 github.com
drwxr-xr-x   3 ...  primarygroup    96 Oct 17 15:33 go.opencensus.io
drwxr-xr-x   3 ...  primarygroup    96 Oct 17 15:33 go.opentelemetry.io
drwxr-xr-x   5 ...  primarygroup   160 Oct 17 15:33 go.uber.org
drwxr-xr-x   3 ...  primarygroup    96 Oct 17 15:33 golang.org
drwxr-xr-x   6 ...  primarygroup   192 Oct 17 15:33 google.golang.org
drwxr-xr-x   6 ...  primarygroup   192 Oct 17 15:33 gopkg.in
drwxr-xr-x  12 ...  primarygroup   384 Oct 17 15:33 k8s.io
drwxr-xr-x   5 ...  primarygroup   160 Oct 17 15:33 sigs.k8s.io

$ head -15 ./here/licenses/cloud.google.com/go/compute/metadata/LICENSE 

                                 Apache License
                           Version 2.0, January 2004
                        http://www.apache.org/licenses/

   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

   1. Definitions.

      "License" shall mean the terms and conditions for use, reproduction,
      and distribution as defined by Sections 1 through 9 of this document.

      "Licensor" shall mean the copyright owner or entity authorized by
      the copyright owner that is granting the License.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2022
medyagh
medyagh approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u plz paste in the PR description example of the output?

@spowelljr
Copy link
Member Author

can u plz paste in the PR description example of the output?

It already does, running the command generates a licenses dir that contains all the licenses, I updated the description to use the tree command is that makes it easier to see.

medyagh
medyagh requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking License is a better name than Credit
since credit might imply the contributors to minikube which is misleading

@spowelljr spowelljr changed the title Add minikube credits command Add minikube license command Oct 20, 2022
@spowelljr
Copy link
Member Author

spowelljr commented Oct 20, 2022 •
edited
Loading

I am thinking License is a better name than Credit since credit might imply the contributors to minikube which is misleading

Renamed the command from credits to license

@medyagh medyagh self-requested a review October 21, 2022 23:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Oct 21, 2022

Would be nice to have an integration test for it

@medyagh
Copy link
Member

medyagh commented Oct 21, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 21, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 57.5s    | 56.7s               |
| enable ingress | 29.0s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 59.4s 57.2s 58.5s 56.5s 55.7s
Times for minikube (PR 15158) start: 56.2s 56.0s 57.0s 57.2s 57.3s

Times for minikube ingress: 29.2s 29.2s 28.6s 29.2s 28.7s
Times for minikube (PR 15158) ingress: 28.7s 28.2s 30.6s 28.7s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 27.8s    | 27.7s               |
| enable ingress | 35.8s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 28.2s 26.5s 27.1s 30.3s 27.0s
Times for minikube (PR 15158) start: 27.6s 27.4s 26.8s 28.0s 28.5s

Times for minikube ingress: 22.5s 23.5s 23.0s 26.6s 83.5s
Times for minikube (PR 15158) ingress: 22.5s 23.0s 20.5s 22.0s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 25.3s               |
| enable ingress | 27.1s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 35.6s 23.7s 25.2s 27.6s 24.1s
Times for minikube (PR 15158) start: 24.4s 24.5s 27.8s 25.2s 24.9s

Times for minikube ingress: 27.0s 27.0s 27.0s 27.5s 27.0s
Times for minikube (PR 15158) ingress: 27.0s 27.0s 27.0s 27.0s 27.0s

@spowelljr
Copy link
Member Author

Would be nice to have an integration test for it

Added a functional test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 55.5s    | 56.0s               |
| enable ingress | 26.8s    | 28.8s               |
+----------------+----------+---------------------+

Times for minikube start: 55.3s 55.3s 54.0s 57.4s 55.5s
Times for minikube (PR 15158) start: 57.3s 55.7s 55.5s 55.0s 56.4s

Times for minikube ingress: 25.1s 28.6s 25.7s 25.6s 28.7s
Times for minikube (PR 15158) ingress: 29.6s 26.1s 30.7s 28.6s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 27.8s    | 27.2s               |
| enable ingress | 22.7s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 28.1s 27.7s 28.7s 27.8s 26.5s
Times for minikube (PR 15158) start: 27.1s 27.6s 27.4s 26.7s 27.5s

Times for minikube ingress: 22.4s 23.5s 22.0s 23.0s 22.5s
Times for minikube (PR 15158) ingress: 23.0s 23.5s 22.0s 22.0s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 27.9s    | 26.6s               |
| enable ingress | 27.1s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 15158) start: 25.5s 24.3s 24.3s 24.0s 34.9s
Times for minikube start: 23.8s 28.0s 25.0s 35.0s 27.6s

Times for minikube ingress: 27.0s 27.5s 26.9s 27.0s 26.9s
Times for minikube (PR 15158) ingress: 27.0s 26.9s 27.0s 27.5s 27.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/NetCatPod (gopogh) 0.00 (chart)
Hyperkit_macOS TestOffline (gopogh) 0.76 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/SSHCmd (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/parallel/Version/components (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/serial/ComponentHealth (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/serial/ExtraConfig (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/serial/LogsCmd (gopogh) 42.86 (chart)
Docker_Windows TestFunctional/serial/LogsFileCmd (gopogh) 42.86 (chart)
Docker_Windows TestJSONOutput/start/parallel/DistinctCurrentSteps (gopogh) 42.86 (chart)
Docker_Windows TestJSONOutput/start/parallel/IncreasingCurrentSteps (gopogh) 42.86 (chart)
Docker_Windows TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 42.86 (chart)
Docker_Windows TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 42.86 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestFunctional/parallel/License (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/License (gopogh) n/a
Docker_Linux TestFunctional/parallel/License (gopogh) n/a
Docker_macOS TestFunctional/parallel/License (gopogh) n/a
Docker_Windows TestFunctional/parallel/License (gopogh) n/a
Hyperkit_macOS TestFunctional/parallel/License (gopogh) n/a
Hyper-V_Windows TestFunctional/parallel/License (gopogh) n/a
KVM_Linux_containerd TestFunctional/parallel/License (gopogh) n/a
KVM_Linux TestFunctional/parallel/License (gopogh) n/a
Docker_Linux TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/Ingress (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/Registry (gopogh) 0.00 (chart)
Docker_Linux TestAddons/serial/GCPAuth (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/serial/ComponentHealth (gopogh) 42.54 (chart)
Docker_Windows TestFunctional/serial/ExtraConfig (gopogh) 42.54 (chart)
Docker_Windows TestFunctional/serial/LogsCmd (gopogh) 42.54 (chart)
Docker_Windows TestFunctional/serial/LogsFileCmd (gopogh) 42.54 (chart)
Docker_Windows TestAddons/Setup (gopogh) 52.99 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/KubeContext (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/KubectlGetPods (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/MinikubeKubectlCmd (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/SoftStart (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/serial/StartWithProxy (gopogh) 52.99 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 55.8s    | 55.9s               |
| enable ingress | 28.0s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 56.1s 54.7s 56.1s 56.0s 56.4s
Times for minikube (PR 15158) start: 56.7s 56.0s 56.0s 56.0s 54.6s

Times for minikube ingress: 28.6s 28.7s 24.7s 28.7s 29.2s
Times for minikube (PR 15158) ingress: 24.6s 28.7s 29.1s 28.7s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 27.7s    | 27.6s               |
| enable ingress | 22.3s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube start: 27.3s 26.0s 30.2s 26.7s 28.5s
Times for minikube (PR 15158) start: 27.7s 26.9s 26.4s 29.5s 27.5s

Times for minikube ingress: 22.0s 22.5s 23.5s 22.5s 21.0s
Times for minikube (PR 15158) ingress: 24.0s 23.0s 24.0s 22.0s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15158) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 24.5s               |
| enable ingress | 27.1s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube start: 24.2s 24.7s 24.6s 23.8s 30.0s
Times for minikube (PR 15158) start: 23.7s 23.8s 23.9s 24.4s 26.9s

Times for minikube ingress: 27.0s 27.0s 27.0s 27.0s 27.5s
Times for minikube (PR 15158) ingress: 27.0s 28.0s 27.0s 27.5s 27.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 15.67 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 37.50 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 39.71 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 40.57 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 40.57 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 40.57 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 40.57 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 41.12 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 41.12 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 41.12 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 41.67 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/SSHCmd (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 42.14 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 42.14 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 57d4c7d into kubernetes:master Oct 24, 2022
@spowelljr spowelljr deleted the minikubeCredits branch October 24, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spowelljr @k8s-ci-robot @medyagh @minikube-pr-bot