Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist mount settings after stop start #12719

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Persist mount settings after stop start #12719

merged 3 commits into from
Oct 19, 2021

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Oct 15, 2021 •
edited
Loading

Closes #12718

Problem:
Mount settings wouldn't persist after a stop start sequence on VM drivers, so after a stop if you wanted to mount again you'd have to re-specify the mount flags.

Solution:
Save the --mount & --mount-string flags to config.json and pull them on restart.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2021
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 47.1s               |
| enable ingress | 31.5s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 50.4s 47.0s 47.9s 46.1s 46.8s
Times for minikube (PR 12719) start: 47.1s 46.5s 48.2s 46.9s 46.8s

Times for minikube ingress: 31.3s 32.8s 30.8s 32.2s 30.2s
Times for minikube (PR 12719) ingress: 31.3s 30.8s 31.8s 31.3s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.7s               |
| enable ingress | 29.2s    | 30.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 21.4s 21.6s 21.7s 21.9s
Times for minikube (PR 12719) start: 22.3s 21.2s 20.8s 21.7s 22.4s

Times for minikube ingress: 27.4s 26.9s 28.4s 35.4s 27.9s
Times for minikube (PR 12719) ingress: 34.9s 35.4s 27.0s 27.9s 27.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 41.0s    | 42.5s               |
| enable ingress | 35.4s    | 40.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12719) start: 43.7s 36.4s 43.6s 44.3s 44.5s
Times for minikube start: 31.5s 44.3s 43.4s 43.3s 42.6s

Times for minikube (PR 12719) ingress: 32.4s 70.9s 29.9s 33.4s 36.9s
Times for minikube ingress: 35.4s 37.9s 28.4s 37.5s 37.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 46.6s               |
| enable ingress | 30.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 12719) start: 46.4s 47.8s 46.8s 45.9s 45.9s
Times for minikube start: 50.5s 45.0s 47.1s 47.1s 45.7s

Times for minikube (PR 12719) ingress: 31.8s 31.9s 31.2s 31.3s 31.3s
Times for minikube ingress: 30.8s 29.8s 31.3s 31.3s 30.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.2s               |
| enable ingress | 26.9s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 12719) ingress: 26.9s 27.4s 33.9s 26.9s 25.9s
Times for minikube ingress: 27.4s 27.4s 26.4s 27.9s 25.5s

Times for minikube start: 22.7s 21.1s 21.4s 22.7s 20.7s
Times for minikube (PR 12719) start: 21.6s 21.2s 20.9s 20.9s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 38.5s    | 41.9s               |
| enable ingress | 31.6s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 27.5s 43.0s 43.4s 43.0s 35.6s
Times for minikube (PR 12719) start: 36.1s 42.6s 46.2s 42.6s 42.2s

Times for minikube (PR 12719) ingress: 36.4s 52.9s 28.4s 32.9s 22.9s
Times for minikube ingress: 32.4s 32.9s 32.9s 32.9s 26.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) n/a
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) n/a
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) n/a
Docker_Windows TestMountStart/serial/Stop (gopogh) n/a
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) n/a
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) n/a
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) n/a
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) n/a
KVM_Linux_containerd TestMountStart/serial/RestartStopped (gopogh) n/a
KVM_Linux_containerd TestMountStart/serial/Stop (gopogh) n/a
KVM_Linux TestMountStart/serial/RestartStopped (gopogh) n/a
KVM_Linux TestMountStart/serial/Stop (gopogh) n/a
Hyper-V_Windows TestPause/serial/Pause (gopogh) 0.00 (chart)
Hyper-V_Windows TestPause/serial/VerifyStatus (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 2.08 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/NetCatPod (gopogh) 2.44 (chart)
Hyper-V_Windows TestPause/serial/PauseAgain (gopogh) 8.33 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 10.07 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 26.17 (chart)
Docker_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 26.17 (chart)
Docker_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 26.17 (chart)
Docker_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 26.17 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 46.31 (chart)
Hyper-V_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 62.50 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 62.50 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 62.50 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 72.00 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 83.33 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 83.89 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 87.61 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) n/a
Docker_Windows TestMountStart/serial/Stop (gopogh) n/a
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) n/a
KVM_Linux_containerd TestMountStart/serial/RestartStopped (gopogh) n/a
KVM_Linux_containerd TestMountStart/serial/Stop (gopogh) n/a
KVM_Linux TestMountStart/serial/RestartStopped (gopogh) n/a
KVM_Linux TestMountStart/serial/Stop (gopogh) n/a
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) 0.00 (chart)
Docker_Linux_containerd TestOffline (gopogh) 1.32 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 7.84 (chart)
Docker_Linux TestPause/serial/VerifyStatus (gopogh) 7.84 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 15.00 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 28.57 (chart)
Docker_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 28.57 (chart)
Docker_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 28.57 (chart)
Docker_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 28.57 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 71.67 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 72.14 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/DNS (gopogh) 74.36 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 82.86 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 82.88 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 87.50 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)
Docker_Windows TestPause/serial/VerifyDeletedResources (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 46.8s               |
| enable ingress | 31.5s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 48.3s 48.9s 46.3s 47.8s 47.5s
Times for minikube (PR 12719) start: 48.0s 45.5s 46.0s 46.0s 48.6s

Times for minikube ingress: 30.8s 30.8s 30.8s 32.8s 32.3s
Times for minikube (PR 12719) ingress: 31.3s 31.7s 30.2s 31.3s 31.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 20.8s               |
| enable ingress | 28.6s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.5s 26.9s 26.9s 27.4s 34.4s
Times for minikube (PR 12719) ingress: 26.9s 26.4s 26.4s 27.0s 26.4s

Times for minikube start: 22.3s 22.2s 21.7s 21.5s 21.1s
Times for minikube (PR 12719) start: 20.6s 20.5s 20.9s 20.6s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 42.9s               |
| enable ingress | 31.1s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 31.9s 43.7s 43.8s 42.5s 41.2s
Times for minikube (PR 12719) start: 40.2s 43.4s 43.8s 43.8s 43.5s

Times for minikube ingress: 28.9s 28.5s 32.5s 33.0s 32.5s
Times for minikube (PR 12719) ingress: 32.4s 32.5s 19.0s 32.5s 28.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) n/a
Docker_Windows TestMountStart/serial/Stop (gopogh) n/a
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) n/a
KVM_Linux_containerd TestMountStart/serial/RestartStopped (gopogh) n/a
KVM_Linux_containerd TestMountStart/serial/Stop (gopogh) n/a
KVM_Linux TestMountStart/serial/RestartStopped (gopogh) n/a
KVM_Linux TestMountStart/serial/Stop (gopogh) n/a
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) 0.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 2.52 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 8.16 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 8.81 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 23.27 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 38.10 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 45.58 (chart)
Docker_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 45.58 (chart)
Docker_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 45.58 (chart)
Docker_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 45.58 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 73.47 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 75.56 (chart)
Hyper-V_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 76.00 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 76.00 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 76.00 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 82.54 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 82.99 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 85.16 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr force-pushed the retainMountAfterStop branch from fb818a9 to ecebde8 Compare October 18, 2021 22:40
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 46.7s               |
| enable ingress | 32.1s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 48.6s 48.3s 47.9s 46.6s 46.7s
Times for minikube (PR 12719) start: 47.9s 47.8s 45.7s 45.5s 46.6s

Times for minikube ingress: 32.3s 31.8s 33.3s 31.4s 31.8s
Times for minikube (PR 12719) ingress: 31.3s 31.8s 31.7s 31.8s 34.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.8s               |
| enable ingress | 31.0s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12719) ingress: 27.9s 27.9s 34.4s 26.9s 26.4s
Times for minikube ingress: 45.4s 28.0s 27.9s 26.9s 26.9s

Times for minikube start: 22.0s 20.8s 21.7s 22.0s 22.1s
Times for minikube (PR 12719) start: 21.9s 21.5s 21.2s 22.4s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12719) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 43.8s               |
| enable ingress | 33.8s    | 36.8s               |
+----------------+----------+---------------------+

Times for minikube start: 32.5s 43.8s 43.4s 43.8s 43.2s
Times for minikube (PR 12719) start: 44.0s 44.0s 44.2s 43.3s 43.5s

Times for minikube ingress: 32.9s 33.4s 36.5s 29.4s 36.9s
Times for minikube (PR 12719) ingress: 66.9s 28.4s 32.9s 36.4s 19.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestGvisorAddon (gopogh) 0.65 (chart)
KVM_Linux_containerd TestPause/serial/PauseAgain (gopogh) 5.84 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 16.23 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit c11ecd2 into kubernetes:master Oct 19, 2021
@spowelljr spowelljr deleted the retainMountAfterStop branch October 19, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM drivers: --mount & --mount-string doesn't persist between stops
4 participants
@spowelljr @minikube-pr-bot @k8s-ci-robot @medyagh