Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade buildkit from 0.8.2 to 0.9.0 #12032

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jul 21, 2021

Related #9947

Upgrading buildkit to the newest version

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@spowelljr
Copy link
Member Author

/ok-to-build-image

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 21, 2021

Are you willing to try the systemd unit ?

examples/systemd/
├── buildkit.service
└── buildkit.socket

Might need to change the path, though.

@spowelljr
Copy link
Member Author

Are you willing to try the systemd unit ?
examples/systemd/
├── buildkit.service
└── buildkit.socket
Might need to change the path, though.

@afbjorklund Since we both tried this and it seems to work, would you be interested in reviewing this?

@afbjorklund
Copy link
Collaborator

We can do the systemd unit in the other PR, and just do the version upgrade here ?

@spowelljr
Copy link
Member Author

@afbjorklund Yeah, that was my plan, or we could do them together, doesn't really matter to me.

@medyagh
Copy link
Member

medyagh commented Aug 9, 2021

/ok-to-build-image

that one is for KIC and needs without / . :)

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@spowelljr
Copy link
Member Author

ok-to-build-image

@kubernetes kubernetes deleted a comment from minikube-bot Aug 10, 2021
@kubernetes kubernetes deleted a comment from minikube-bot Aug 10, 2021
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2021
@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 10, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12032) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 47.9s               |
| enable ingress | 33.2s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 47.5s 48.4s 47.7s 49.5s
Times for minikube (PR 12032) start: 48.3s 46.5s 46.9s 50.4s 47.5s

Times for minikube ingress: 31.3s 31.8s 39.3s 31.7s 31.8s
Times for minikube (PR 12032) ingress: 32.2s 33.2s 32.3s 31.8s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12032) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 30.5s               |
| enable ingress | 34.8s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 21.7s 21.7s 22.8s 22.0s
Times for minikube (PR 12032) start: 64.1s 22.3s 21.9s 23.0s 21.3s

Times for minikube ingress: 36.0s 35.5s 35.5s 31.5s 35.5s
Times for minikube (PR 12032) ingress: 35.5s 37.5s 33.0s 35.5s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12032) |
+----------------+----------+---------------------+
| minikube start | 43.4s    | 41.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.5s 43.1s 42.9s 44.4s 43.4s
Times for minikube (PR 12032) start: 29.7s 43.6s 43.8s 44.6s 44.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.68 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/no-preload/serial/DeployApp (gopogh) 1.39 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/BuildImage (gopogh) 2.07 (chart)
Docker_Linux_docker_arm64 TestFunctional/serial/ComponentHealth (gopogh) 2.83 (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
Docker_Windows TestPause/serial/Start (gopogh) 3.97 (chart)
Docker_Windows TestOffline (gopogh) 5.38 (chart)
Docker_Linux_crio TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 6.04 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 6.92 (chart)
Docker_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 6.98 (chart)
KVM_Linux_crio TestAddons/parallel/GCPAuth (gopogh) 7.80 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 8.97 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/BuildImage (gopogh) 8.97 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 9.23 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 10.34 (chart)
Docker_macOS TestScheduledStopUnix (gopogh) 11.01 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 12.41 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 13.10 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 13.79 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 16.78 (chart)
Docker_Windows TestInsufficientStorage (gopogh) 23.08 (chart)
KVM_Linux TestScheduledStopUnix (gopogh) 24.49 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 32.31 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit adbeae1 into kubernetes:master Aug 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the updateBuildkit branch August 13, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants