addon list: Add info on each addon's maintainer #11753

andriyDev · 2021-06-23T16:43:03Z

Some of these addons still need proper maintainers, we need to ask those who created the addons whether they are willing to be points of contact.

$ minikube addons list
|-----------------------------|----------|--------------|-----------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |      MAINTAINER       |
|-----------------------------|----------|--------------|-----------------------|
| ambassador                  | minikube | disabled     | unknown (third-party) |
| auto-pause                  | minikube | disabled     | google                |
| csi-hostpath-driver         | minikube | disabled     | kubernetes            |
| dashboard                   | minikube | disabled     | kubernetes            |
| default-storageclass        | minikube | enabled ✅   | kubernetes            |
| efk                         | minikube | disabled     | unknown (third-party) |
| freshpod                    | minikube | disabled     | google                |
| gcp-auth                    | minikube | disabled     | google                |
| gvisor                      | minikube | disabled     | google                |
| helm-tiller                 | minikube | disabled     | unknown (third-party) |
| ingress                     | minikube | disabled     | unknown (third-party) |
| ingress-dns                 | minikube | disabled     | unknown (third-party) |
| istio                       | minikube | disabled     | unknown (third-party) |
| istio-provisioner           | minikube | disabled     | unknown (third-party) |
| kubevirt                    | minikube | disabled     | unknown (third-party) |
| logviewer                   | minikube | disabled     | google                |
| metallb                     | minikube | disabled     | unknown (third-party) |
| metrics-server              | minikube | disabled     | kubernetes            |
| nvidia-driver-installer     | minikube | disabled     | google                |
| nvidia-gpu-device-plugin    | minikube | disabled     | unknown (third-party) |
| olm                         | minikube | disabled     | unknown (third-party) |
| pod-security-policy         | minikube | disabled     | unknown (third-party) |
| registry                    | minikube | disabled     | google                |
| registry-aliases            | minikube | disabled     | unknown (third-party) |
| registry-creds              | minikube | disabled     | unknown (third-party) |
| storage-provisioner         | minikube | enabled ✅   | kubernetes            |
| storage-provisioner-gluster | minikube | disabled     | unknown (third-party) |
| volumesnapshots             | minikube | disabled     | kubernetes            |
|-----------------------------|----------|--------------|-----------------------|

medyagh

plz paste the output in the pr description list

andriyDev · 2021-06-23T16:45:28Z

@medyagh I knew I was missing something obvious :P

minikube-bot · 2021-06-23T16:50:05Z

Can one of the admins verify this patch?

andriyDev · 2021-06-23T16:50:22Z

/ok-to-test

pkg/minikube/assets/addons.go

medyagh · 2021-06-23T17:07:13Z

pkg/minikube/assets/addons.go

@@ -311,7 +313,7 @@ var Addons = map[string]*Addon{
 			vmpath.GuestAddonsDir,
 			"olm.yaml",
 			"0640"),
-	}, false, "olm", map[string]string{
+	}, false, "olm", "OLM", map[string]string{


this could be change t third party till we confirm

and also instead of OLM we could use their github org

https://github.com/operator-framework/

we should create a follow up issue to contact the owners of those repos to see if they consent their org to be added offically as maintainer/responsible fr this addon, so in case olm image has anything malscious in it, they be point of contact for it ?

or maybe we could use the company name redhat for olm addon?

Wdyt @ecordell @njhale @benluddy

minikube-pr-bot · 2021-06-23T17:44:20Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 46.8s    | 46.6s               |
| enable ingress | 40.8s    | 40.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 42.3s 34.3s 42.2s 41.7s 43.3s
Times for minikube (PR 11753) ingress: 39.2s 41.8s 35.8s 42.2s 42.7s

Times for minikube start: 49.1s 46.1s 46.9s 46.6s 45.5s
Times for minikube (PR 11753) start: 46.8s 46.9s 45.3s 47.9s 46.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 21.6s               |
| enable ingress | 38.3s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 38.0s 38.0s 43.5s 37.5s 34.5s
Times for minikube (PR 11753) ingress: 32.5s 36.0s 34.0s 34.9s 34.5s

Times for minikube start: 21.2s 21.1s 20.9s 22.1s 21.5s
Times for minikube (PR 11753) start: 21.9s 21.2s 22.2s 21.0s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 45.7s    | 45.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 47.3s 47.3s 43.5s 42.3s 47.8s
Times for minikube (PR 11753) start: 42.5s 47.9s 47.6s 43.3s 47.9s

minikube-bot · 2021-06-23T18:13:31Z

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests	Flake Rate (%)
TestPause/serial/Pause	0.00 (chart)
TestPause/serial/VerifyStatus	0.00 (chart)

minikube-bot · 2021-06-23T18:21:27Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/PauseAgain	16.67 (chart)

minikube-pr-bot · 2021-06-24T18:34:27Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 48.9s               |
| enable ingress | 34.4s    | 36.2s               |
+----------------+----------+---------------------+

Times for minikube start: 54.4s 47.9s 55.2s 47.7s 47.0s
Times for minikube (PR 11753) start: 50.5s 47.3s 51.6s 47.3s 48.0s

Times for minikube ingress: 36.4s 33.7s 33.7s 33.7s 34.3s
Times for minikube (PR 11753) ingress: 37.2s 35.4s 35.2s 36.7s 36.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.8s               |
| enable ingress | 29.3s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 22.4s 22.8s 23.5s 22.1s
Times for minikube (PR 11753) start: 22.6s 22.1s 22.9s 23.0s 23.5s

Times for minikube ingress: 29.0s 29.0s 29.5s 31.5s 27.5s
Times for minikube (PR 11753) ingress: 29.5s 29.0s 29.0s 29.5s 29.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 44.9s    | 44.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.1s 47.3s 44.7s 44.2s 43.4s
Times for minikube (PR 11753) start: 43.0s 42.7s 43.3s 49.2s 44.2s

minikube-bot · 2021-06-24T18:37:26Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestKubernetesUpgrade	2.02 (chart)

k8s-ci-robot · 2021-06-25T20:00:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andriyDev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-06-25T20:27:20Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.9s               |
| enable ingress | 37.9s    | 37.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 11753) start: 51.6s 47.1s 47.1s 47.1s 46.7s
Times for minikube start: 47.4s 47.4s 48.4s 47.6s 47.5s

Times for minikube (PR 11753) ingress: 34.8s 41.7s 39.2s 34.8s 35.3s
Times for minikube ingress: 35.8s 41.8s 34.3s 35.2s 42.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 22.1s               |
| enable ingress | 34.7s    | 33.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.4s 38.5s 33.5s 34.5s 33.5s
Times for minikube (PR 11753) ingress: 32.0s 33.0s 33.5s 35.5s 32.5s

Times for minikube start: 22.3s 21.7s 21.4s 21.4s 21.5s
Times for minikube (PR 11753) start: 21.9s 21.8s 21.8s 22.6s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11753) |
+----------------+----------+---------------------+
| minikube start | 41.8s    | 43.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.9s 47.2s 43.4s 43.9s 43.4s
Times for minikube (PR 11753) start: 42.6s 42.6s 43.3s 43.4s 47.2s

minikube-bot · 2021-06-25T20:29:19Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestNetworkPlugins/group/false/DNS	1.83 (chart)

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2021

k8s-ci-robot requested review from medyagh and prezha June 23, 2021 16:43

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2021

medyagh reviewed Jun 23, 2021

View reviewed changes

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 23, 2021

medyagh requested changes Jun 23, 2021

View reviewed changes

pkg/minikube/assets/addons.go Show resolved Hide resolved

medyagh requested changes Jun 23, 2021

View reviewed changes

Add maintainer column to addons list.

b5df84a

andriyDev force-pushed the AddonMaintainers branch from 310773b to 5f5a0c7 Compare June 24, 2021 17:15

Add maintainers that are certain.

2f523eb

andriyDev force-pushed the AddonMaintainers branch from 5f5a0c7 to 2f523eb Compare June 25, 2021 19:14

medyagh approved these changes Jun 25, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021

medyagh merged commit 512ae30 into kubernetes:master Jun 25, 2021

medyagh changed the title ~~Add maintainer column to addons list~~ addon list: Add info on each addon's maintainer Jun 25, 2021

andriyDev deleted the AddonMaintainers branch August 5, 2021 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

addon list: Add info on each addon's maintainer #11753

addon list: Add info on each addon's maintainer #11753

andriyDev commented Jun 23, 2021 •

edited

Loading

medyagh left a comment

andriyDev commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

andriyDev commented Jun 23, 2021

medyagh Jun 23, 2021

medyagh Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 24, 2021

minikube-bot commented Jun 24, 2021

k8s-ci-robot commented Jun 25, 2021

minikube-pr-bot commented Jun 25, 2021

minikube-bot commented Jun 25, 2021

addon list: Add info on each addon's maintainer #11753

addon list: Add info on each addon's maintainer #11753

Conversation

andriyDev commented Jun 23, 2021 • edited Loading

medyagh left a comment

Choose a reason for hiding this comment

andriyDev commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

andriyDev commented Jun 23, 2021

medyagh Jun 23, 2021

Choose a reason for hiding this comment

medyagh Jun 23, 2021

Choose a reason for hiding this comment

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 24, 2021

minikube-bot commented Jun 24, 2021

k8s-ci-robot commented Jun 25, 2021

minikube-pr-bot commented Jun 25, 2021

minikube-bot commented Jun 25, 2021

andriyDev commented Jun 23, 2021 •

edited

Loading