-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO: Add packaging for crun #11679
ISO: Add packaging for crun #11679
Conversation
Why do we need crun? |
CRI-O defaults to crun under certain conditions, mostly Cgroups V2 I think |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ok-to-build-iso |
Hi @afbjorklund, building a new ISO failed. |
KIC is currently including crun 1.2 from kubic,
EDIT: Reverted the upgrade |
ok-to-build-iso |
Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
ok-to-build-iso |
Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube (PR 11679) start: 52.0s 52.8s 50.6s 52.4s 52.7s Times for minikube ingress: 29.0s 29.0s 29.5s 25.1s 29.6s docker driver with docker runtime
Times for minikube start: 26.0s 27.0s 26.5s 26.3s 25.6s Times for minikube ingress: 22.9s 22.4s 20.4s 22.9s 22.9s docker driver with containerd runtime
Times for minikube start: 47.5s 41.7s 42.1s 41.3s 41.3s Times for minikube ingress: 17.9s 21.9s 22.4s 21.9s 22.4s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Any work planned for crun 1.2+, like crun 1.4.4 ? |
Currently there are no Ubuntu 20.04 binaries after Podman 3.4.2 and crun 1.2, so left it the same in the ISO... Might have to use binaries also in KIC, if we want to bump to 3.4.4 and 1.4.x Is there anything important? |
@afbjorklund Ok, good to know -- just interested in when the fixed CVEs were going to be included |
It seems like podman gave up on packaging mid-air, so I think we will have to use some PPA or do our own packages https://build.opensuse.org/project/show/devel:kubic:libcontainers:stable
|
I think it is left to each OS vendor, because https://koji.fedoraproject.org/koji/packageinfo?packageID=9688 |
minikube uses podman for building images and for loading images, so normally it is cri-o Using minikube to run containers with podman is probably unsupported. Can use podman machine for that instead. |
Yeah well, it seems that it would require changing distribution https://packages.ubuntu.com/focal/crun Currently we are using vendor packages, but they stopped updating them. So might have to reconsider that. |
https://github.com/containers/crun