Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running amd64 binary on M1 #11674

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Allow running amd64 binary on M1 #11674

merged 5 commits into from
Jun 25, 2021

Conversation

ilya-zuyev
Copy link
Contributor

@ilya-zuyev ilya-zuyev commented Jun 16, 2021 •
edited
Loading

This PR relaxes limitations we have on running darwin/amd64 binaries on darwin/arm64 platform.

Note: deployed k8s version is still arm64

Before

ilyaz@m1host --- z/minikube ‹master*➔ ?› » out/minikube-darwin-amd64 start                  

❌  Exiting due to MK_WRONG_BINARY_M1: You are trying to run amd64 binary on M1 system. Please use darwin/arm64 binary instead (Download at https://github.com/kubernetes/minikube/releases/download/v1.21.0/minikube-darwin-arm64.)

After

ilyaz@m1host --- z/minikube ‹ilyaz/m1_amd64*➔ ?› » out/minikube-darwin-amd64 start      
    ▪ You are trying to run amd64 binary on M1 system. Please consider running darwin/arm64 binary instead (Download at https://github.com/kubernetes/minikube/releases/download/v1.21.0/minikube-darwin-arm64.)
😄  minikube v1.21.0 on Darwin 11.2
✨  Automatically selected the docker driver
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.7 preload ...
    > gcr.io/k8s-minikube/kicbase...: 359.09 MiB / 359.09 MiB  100.00% 4.90 MiB
    > preloaded-images-k8s-v11-v1...: 515.57 MiB / 515.57 MiB  100.00% 5.99 MiB

🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.20.7 on Docker 20.10.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2021
medyagh
medyagh requested changes Jun 21, 2021
View reviewed changes
cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@ilya-zuyev ilya-zuyev changed the title [wip] Allow running amd64 bianry on M1 [wip] Allow running amd64 binary on M1 Jun 22, 2021
@ilya-zuyev ilya-zuyev changed the title [wip] Allow running amd64 binary on M1 Allow running amd64 binary on M1 Jun 24, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 24, 2021
@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests Flake Rate (%)
TestScheduledStopUnix 3.96 (chart)

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11674) |
+----------------+----------+---------------------+
| minikube start | 49.1s    | 47.0s               |
| enable ingress | 33.9s    | 33.3s               |
+----------------+----------+---------------------+

Times for minikube start: 47.6s 51.0s 47.3s 48.2s 51.2s
Times for minikube (PR 11674) start: 46.9s 47.4s 47.0s 46.3s 47.2s

Times for minikube ingress: 34.3s 33.3s 32.8s 34.7s 34.3s
Times for minikube (PR 11674) ingress: 33.3s 32.7s 34.2s 32.7s 33.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11674) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.3s               |
| enable ingress | 29.9s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 11674) start: 23.0s 21.3s 22.4s 22.6s 22.2s
Times for minikube start: 21.5s 21.7s 22.0s 22.7s 21.6s

Times for minikube ingress: 31.0s 29.0s 29.0s 30.5s 30.0s
Times for minikube (PR 11674) ingress: 26.5s 27.5s 26.0s 29.0s 30.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11674) |
+----------------+----------+---------------------+
| minikube start | 43.5s    | 44.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11674) start: 47.3s 43.6s 43.5s 42.9s 43.3s
Times for minikube start: 44.7s 43.2s 43.4s 43.0s 43.5s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11674) |
+----------------+----------+---------------------+
| minikube start | 52.7s    | 53.7s               |
| enable ingress | 40.4s    | 40.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 11674) ingress: 35.4s 42.5s 45.4s 41.3s 36.4s
Times for minikube ingress: 42.4s 37.3s 34.9s 44.8s 42.8s

Times for minikube start: 54.0s 52.1s 53.2s 51.7s 52.7s
Times for minikube (PR 11674) start: 52.6s 52.5s 53.6s 53.4s 56.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11674) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.2s               |
| enable ingress | 33.6s    | 33.5s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 24.4s 23.4s 22.8s 23.8s
Times for minikube (PR 11674) start: 23.1s 22.7s 23.7s 23.0s 23.3s

Times for minikube ingress: 33.6s 32.0s 35.5s 33.5s 33.6s
Times for minikube (PR 11674) ingress: 33.1s 37.6s 30.0s 33.5s 33.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11674) |
+----------------+----------+---------------------+
| minikube start | 42.9s    | 45.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11674) start: 44.0s 44.2s 44.6s 48.7s 43.9s
Times for minikube start: 33.4s 44.2s 44.4s 48.5s 44.0s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ilya-zuyev,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 52d88fb into kubernetes:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@spowelljr spowelljr spowelljr approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ilya-zuyev @k8s-ci-robot @minikube-bot @minikube-pr-bot @medyagh @spowelljr @ilyazz