Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validations --image-repository inputs #10760

Merged
merged 2 commits into from
Mar 10, 2021
Merged

add validations --image-repository inputs #10760

merged 2 commits into from
Mar 10, 2021

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Mar 9, 2021 •
edited
Loading

add validateImageRepository func for validates --image-repository args
This PR fix two error:

  1. when --image-repository endswith "/", k8s can't start, because static pod image contain "//"
  2. when --image-repository startswieh "http" or "https", it will think of http or https as a domain name.

error msg:
E0309 13:57:24.340121 73314 cache.go:63] save image to file "http:/harbor.example.com/google_images/dashboard:v2.1.0" -> "/home/minikube/.minikube/cache/images/http_/harbor.corp.qunar.com/google_images/dashboard_v2.1.0" failed: nil image for http:/harbor.example.com/google_images/dashboard:v2.1.0: Get "https://http/v2/": dial tcp: lookup http on 192.168.101.58:53: server misbehaving

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @yxxhero!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@yxxhero
Copy link
Member Author

yxxhero commented Mar 9, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@yxxhero: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yxxhero
Copy link
Member Author

yxxhero commented Mar 9, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@yxxhero: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

medyagh
medyagh requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yxxhero thank you very much for fixing this, just a couple review comments

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
medyagh
medyagh requested changes Mar 9, 2021
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2021
@yxxhero yxxhero requested a review from medyagh March 10, 2021 05:30
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error

@yxxhero
Copy link
Member Author

yxxhero commented Mar 10, 2021

/retest

@yxxhero
Copy link
Member Author

yxxhero commented Mar 10, 2021

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error

the errors above because of me? @medyagh Thanks very much.

@yxxhero
Copy link
Member Author

yxxhero commented Mar 10, 2021

/retest

@yxxhero
Copy link
Member Author

yxxhero commented Mar 10, 2021

I check Jenkins faild jobs, I think it not because me. Thanks very much! @medyagh

ohbus
Mar 10, 2021
View reviewed changes
Copy link

@ohbus

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ohbus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yxxhero yxxhero requested a review from medyagh March 10, 2021 11:48
@medyagh medyagh merged commit b3b4807 into kubernetes:master Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, ohbus, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title add validateImageRepository func for validates --image-repository args add validations --image-repository inputs Mar 10, 2021
@yxxhero yxxhero mentioned this pull request Nov 13, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

ohbus ohbus approved these changes

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@ilya-zuyev ilya-zuyev Awaiting requested review from ilya-zuyev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. pr_verified size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yxxhero @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot