Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last start logs to minikube logs output #10465

Merged
merged 11 commits into from
Feb 24, 2021
Merged

Add last start logs to minikube logs output #10465

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
91e8c09
Save start logs to lastStart.txt in minikube dir
spowelljr Feb 13, 2021
f390d1e
Output last start logs during minikube logs
spowelljr Feb 13, 2021
db1363a
Fixed output being jumbled together
spowelljr Feb 16, 2021
610a970
Fixed failing if lastStart.txt file does not exist
spowelljr Feb 17, 2021
2ed6855
added missing err check to scanner and new section logs integration test
spowelljr Feb 19, 2021
b42f8f6
Create logs directory if it does not exist
spowelljr Feb 23, 2021
6794f20
removed duplicate flag check
spowelljr Feb 23, 2021
48652fa
moved import comment
spowelljr Feb 23, 2021
e03bed4
display message if file not found instead of throwing error
spowelljr Feb 23, 2021
7098409
optimized file/dir creation logic
spowelljr Feb 23, 2021
f0902d4
improved func comment
spowelljr Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improved func comment
  • Loading branch information
@spowelljr
spowelljr committed Feb 23, 2021
commit f0902d4ba52c13bc88a29c7c57ab41345561dad8
2 changes: 1 addition & 1 deletion cmd/minikube/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func setFlags() {
}
}

// setLastStartFlags sets the log_file & log_dir flags if start command and no flags provided.
// setLastStartFlags sets the log_file flag to lastStart.txt if start command and user doesn't specify log_file or log_dir flags.
func setLastStartFlags() {
if os.Args[1] != "start" {
return
Expand Down