Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DEVELOPMENT.md to use istio 1.3 #5666

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Update DEVELOPMENT.md to use istio 1.3 #5666

merged 1 commit into from
Nov 26, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Sep 25, 2019 •
edited
Loading

Proposed Changes

This patch updates DEVELOPMENT.md to use istio 1.3. It is
basically same with https://github.com/knative/serving/pull/4512/files
except for third_party/* as they are already updated.

Release Note

NONE

/cc @tcnghia @ZhiminXiang

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 25, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Sep 25, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Sep 26, 2019

It's good to update the e2e-common.sh, but I see that istio-1.3-mesh grid is still not working properly so we should keep advertising 1.2 in the doc for now.

(see https://testgrid.knative.dev/serving#istio-1.3-mesh&exclude-non-failed-tests=20)

@tcnghia
Copy link
Contributor

tcnghia commented Oct 8, 2019

@nak3 Envoy in Istio 1.3 seems to be crashing a lot (see @JRBANCEL 's finding in istio/istio#16357 (comment) ) so we probably want to hold on a bit more before switching to 1.3 as default for test even.

@JRBANCEL
Copy link
Contributor

JRBANCEL commented Oct 8, 2019

It is tracked there now: istio/istio#17699.

@nak3
Copy link
Contributor Author

nak3 commented Oct 8, 2019

/hold

Sure, thank you so much @tcnghia @JRBANCEL

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Nov 25, 2019

It is much less flaky now -- I think we can update to 1.3.

@tcnghia
Copy link
Contributor

tcnghia commented Nov 25, 2019

However I no longer see e2e-common.sh changes. Can you please update PR description?

@tcnghia
Copy link
Contributor

tcnghia commented Nov 25, 2019

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2019
@nak3 nak3 changed the title Update e2e-common.sh and docs to istio 1.3 Update DEVELOPMENT.md to use istio 1.3 Nov 26, 2019
@nak3
Update DEVELOPMENT.md to use istio 1.3 knative#5666
3a48651 
This patch updates DEVELOPMENT.md to use istio 1.3.
@nak3
Copy link
Contributor Author

nak3 commented Nov 26, 2019

@tcnghia Thank you. Sure, I have updated the title of PR and commit message and rebased.

@tcnghia
Copy link
Contributor

tcnghia commented Nov 26, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
markusthoemmes
markusthoemmes approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/assign @mattmoor
superpowers needed.

mattmoor
mattmoor reviewed Nov 26, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, mattmoor, nak3, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@knative-prow-robot knative-prow-robot merged commit 0732d26 into knative:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@tcnghia tcnghia Awaiting requested review from tcnghia

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@tcnghia tcnghia

@markusthoemmes markusthoemmes

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nak3 @tcnghia @JRBANCEL @knative-prow-robot @markusthoemmes @mattmoor @googlebot