Fix race conditions in probe tests. #4786
Conversation
These tests had unguarded access to a shared variable from a HTTP handler. As each HTTP handler runs in its own goroutine, that's racy. This replaces all booleans/counters with atomic counters. Boolean tests are essentially replaced by comparing the counter to be equal to 0.
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
Fixes #4765
Proposed Changes
These tests had unguarded access to a shared variable from a HTTP handler. As each HTTP handler runs in its own goroutine, that's racy.
This replaces all booleans/counters with atomic counters. Boolean tests are essentially replaced by comparing the counter to be equal to 0.
One occurrence is here: https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-serving-continuous/1151252942410485760
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @vagababov |
|
/test pull-knative-serving-unit-tests Fixed in #4784 |
|
Thank you |
Fixes #4765
Proposed Changes
These tests had unguarded access to a shared variable from a HTTP handler. As each HTTP handler runs in its own goroutine, that's racy.
This replaces all booleans/counters with atomic counters. Boolean tests are essentially replaced by comparing the counter to be equal to 0.
One occurrence is here: https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-serving-continuous/1151252942410485760
Release Note