Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated tests. #4751

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Remove outdated tests. #4751

merged 1 commit into from
Jul 16, 2019

Conversation

markusthoemmes
Copy link
Contributor

Proposed Changes

These tests have already been removed by #4721. They have been reintroduced by #4521 by accident.

Release Note

NONE

/assign @mattmoor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 15, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jul 15, 2019
@mattmoor mattmoor assigned dgerd and unassigned mattmoor Jul 15, 2019
vagababov
vagababov reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@vagababov
Copy link
Contributor

/test pull-knative-serving-integration-tests

1 similar comment
@markusthoemmes
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@markusthoemmes
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

Unrelated.

@markusthoemmes
Copy link
Contributor Author

Unrelated.

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit a9441b2 into knative:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@chizhg chizhg Awaiting requested review from chizhg

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@vagababov vagababov

dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markusthoemmes @knative-prow-robot @vagababov @mattmoor @googlebot