Add Raw Node #511
Merged
Add Raw Node #511
+103
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The code around Your change looks great. Thanks so much. I'll review this more carefully a bit later on tonight for me, but so far it looks good and CI is passing! 🤍 |
Remove redundant "plain" output mode; to be added (and tested) if needed.
|
Thanks so much! Let me know if you'd like a release made with your new change. |
|
Yes! If releasing it is straightforward, I would love to see a release with Raw Node so I can start related tasks at work. (I am also hoping that Commonmarker, the Ruby wrapper, gets a new release soon since my work is in Ruby.) |
|
Thank you so much for your review and for v0.32.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the requirements mentioned in #477, Raw Node is added.
I am not sure about the code for Phase::Pre found in src/html.rs and src/xml.rs. I would greatly appreciate it if you could review them.