This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Revert "grub-efi: Remove $cmdpath from configuration for for grub-mki… #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mage" This reverts commit 5fcb2f0. $cmdpath is an important grub environment variable. Remove it will cause the boot failure. Signed-off-by: Yi Zhao <[email protected]>
jiazhang0
reviewed
Nov 25, 2021
| @@ -89,7 +89,7 @@ EOF | |||
| > ${WORKDIR}/cfg | |||
| fi | |||
| cat<<EOF>>${WORKDIR}/cfg | |||
| search.file ${GRUB_PREFIX_DIR}/grub.cfg root | |||
| search.file (\$cmdpath)${GRUB_PREFIX_DIR}/grub.cfg root | |||
There was a problem hiding this comment.
Please help to fix another issue here:
search.file (\$cmdpath)${GRUB_PREFIX_DIR}/grub.cfg
According to https://www.gnu.org/software/grub/manual/grub/html_node/search.html, the default variable used to store the found device is 'root'. In addition, the syntax of search.file command doesn't support the second parameter.
|
@yizhao1 Is there any feedback about this? |
With this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mage"
This reverts commit 5fcb2f0.
$cmdpath is an important grub environment variable. Remove it will cause
the boot failure.
Signed-off-by: Yi Zhao [email protected]