Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing timeout for OIDC token in OIDC tests #742

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Increasing timeout for OIDC token in OIDC tests #742

merged 4 commits into from
Aug 19, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Aug 19, 2024 •
edited by attiasas
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

The flaky failures in OIDC tests occur due to OISC token expiration.
I extended the token expiration duration in order to fix this issue

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 19, 2024
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Aug 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman requested review from attiasas and removed request for hadarshjfrog August 19, 2024 13:31
attiasas
attiasas approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eranturgeman eranturgeman merged commit 3573e07 into jfrog:dev Aug 19, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas