Adding yaml support #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2022 22:30
|
hey @PersonligaPersson sorry for the long due response. YAML support sounds amazing! Happy to merge this PR, would you be able to resolve the conflicts (I have just updated the repo after 2 years)? and I think it would be great to include a small test to try parsing a YAML file, so we can secure this feature and get it tested in the CI. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added basic support for writing YAML in the nsprc configuration file. This was requested in issue #70.
The basic idea was to use the package yaml to parse the .nsprc file. I've ran this code with the the equivalent nsprc files
1070404: active: true notes: my note expiry: '2022-05-30'and
{ "1070404": { "active": true, "notes": "These are my notes", "expiry": '2022-05-30' } }on a project I'm working on which produced the same output.
Let me know if there are any changes needed for the PR to be accepted. Thanks!